From: Josh Durgin <josh.durgin@inktank.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Dan Mick <dan.mick@inktank.com>,
Oliver Francke <Oliver.Francke@filoo.de>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: rbd STDIN import does not work / wip-rbd-export-stdout
Date: Tue, 27 Nov 2012 14:50:17 -0800 [thread overview]
Message-ID: <50B543A9.1080901@inktank.com> (raw)
In-Reply-To: <50B484FF.9070500@profihost.ag>
On 11/27/2012 01:16 AM, Stefan Priebe - Profihost AG wrote:
> Am 26.11.2012 21:00, schrieb Dan Mick:
>> As for fstrim: on the rbd image?....sure, if it's a filesystem, it ought
>> to work (modulo some bugs I've heard about with 32-bit vs. 64-bit
>> offsets in qemu... :) )
> it works fine with my patches i send to qemu. But right now they're no
> upstream an nobody of the qemu people answers anymore. So right now i'll
> keep my patches and be lucky others can't use RBD and fstrim. So maybe
> inktank should push this a bit more to the qemu people.
If you could send another version with PATCHv3 instead of PATCH in the
subject, and a description of the changes since the last version between
the --- and the diffstat, the qemu folks would probably appreciate it.
scripts/checkpatch.pl in qemu.git will warn you about style issues like
the conditionals without braces.
Josh
next prev parent reply other threads:[~2012-11-27 22:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 13:20 rbd STDIN import does not work / wip-rbd-export-stdout Stefan Priebe - Profihost AG
2012-11-26 13:29 ` Oliver Francke
2012-11-26 13:35 ` Stefan Priebe - Profihost AG
2012-11-26 17:34 ` Dan Mick
2012-11-26 19:35 ` Stefan Priebe - Profihost AG
2012-11-26 20:00 ` Dan Mick
2012-11-27 9:16 ` Stefan Priebe - Profihost AG
2012-11-27 22:50 ` Josh Durgin [this message]
2012-11-28 8:09 ` Stefan Priebe - Profihost AG
2012-11-28 18:51 ` Josh Durgin
2012-11-29 10:26 ` Stefan Priebe - Profihost AG
2012-11-28 14:53 ` Stefan Priebe - Profihost AG
2012-12-02 0:27 ` Dan Mick
2012-12-01 20:23 ` Stefan Priebe
2012-12-02 0:28 ` Dan Mick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B543A9.1080901@inktank.com \
--to=josh.durgin@inktank.com \
--cc=Oliver.Francke@filoo.de \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.mick@inktank.com \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.