From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH] ARM: Exynos: Remove unused non-dt support for dwmci controller Date: Wed, 28 Nov 2012 08:31:30 +0900 Message-ID: <50B54D52.8070209@samsung.com> References: <1353914155-1716-1-git-send-email-thomas.abraham@linaro.org> <001301cdcc5c$3e87b0f0$bb9712d0$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:46051 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834Ab2K0Xbi (ORCPT ); Tue, 27 Nov 2012 18:31:38 -0500 Received: by mail-pa0-f46.google.com with SMTP id bh2so6311570pad.19 for ; Tue, 27 Nov 2012 15:31:37 -0800 (PST) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Thomas Abraham Cc: Seungwon Jeon , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com, girish.shivananjappa@linaro.org, jh80.chung@samsung.com, yuvaraj.cd@gmail.com On 11/27/12 17:50, Thomas Abraham wrote: > On 27 November 2012 10:31, Seungwon Jeon wrote: >> On Monday, November 26, 2012, Thomas Abraham wrote: >>> With device tree support enabled for dwmci controller, the unused non-dt support >>> for dwmci controller can be removed. >>> >>> Signed-off-by: Thomas Abraham >>> --- >>> arch/arm/mach-exynos/Makefile | 1 - >>> arch/arm/mach-exynos/dev-dwmci.c | 75 ----------------------------- >>> arch/arm/mach-exynos/include/mach/dwmci.h | 20 -------- >>> 3 files changed, 0 insertions(+), 96 deletions(-) >>> delete mode 100644 arch/arm/mach-exynos/dev-dwmci.c >>> delete mode 100644 arch/arm/mach-exynos/include/mach/dwmci.h >> >> Hi Thomas, >> >> The following parts are remained. Also, no used code. >> Could you check it? >> >> ./plat-samsung/include/plat/devs.h:126:extern struct platform_device exynos4_device_dwmci; >> ./Kconfig:111:config EXYNOS4_DEV_DWMCI > > Hi Seungwon, > > Yes, I have missed that. Thanks for pointing this out. I will take care of this. > I amended the commit as per Seungwon's pointing out. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Wed, 28 Nov 2012 08:31:30 +0900 Subject: [PATCH] ARM: Exynos: Remove unused non-dt support for dwmci controller In-Reply-To: References: <1353914155-1716-1-git-send-email-thomas.abraham@linaro.org> <001301cdcc5c$3e87b0f0$bb9712d0$%jun@samsung.com> Message-ID: <50B54D52.8070209@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/27/12 17:50, Thomas Abraham wrote: > On 27 November 2012 10:31, Seungwon Jeon wrote: >> On Monday, November 26, 2012, Thomas Abraham wrote: >>> With device tree support enabled for dwmci controller, the unused non-dt support >>> for dwmci controller can be removed. >>> >>> Signed-off-by: Thomas Abraham >>> --- >>> arch/arm/mach-exynos/Makefile | 1 - >>> arch/arm/mach-exynos/dev-dwmci.c | 75 ----------------------------- >>> arch/arm/mach-exynos/include/mach/dwmci.h | 20 -------- >>> 3 files changed, 0 insertions(+), 96 deletions(-) >>> delete mode 100644 arch/arm/mach-exynos/dev-dwmci.c >>> delete mode 100644 arch/arm/mach-exynos/include/mach/dwmci.h >> >> Hi Thomas, >> >> The following parts are remained. Also, no used code. >> Could you check it? >> >> ./plat-samsung/include/plat/devs.h:126:extern struct platform_device exynos4_device_dwmci; >> ./Kconfig:111:config EXYNOS4_DEV_DWMCI > > Hi Seungwon, > > Yes, I have missed that. Thanks for pointing this out. I will take care of this. > I amended the commit as per Seungwon's pointing out. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.