All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Raghavendra Prabhu <raghu.prabhu13@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3 0/3] Print when ENOSPC due to lack of inodes.
Date: Tue, 27 Nov 2012 20:52:46 -0600	[thread overview]
Message-ID: <50B57C7E.40002@sandeen.net> (raw)
In-Reply-To: <CAEtq3tN20oZ6NjT37tXo8XYW=N=AFTdsZxWTuD681RPbQeS_iw@mail.gmail.com>

On 10/24/12 3:56 PM, Raghavendra Prabhu wrote:
> Hi,
> 
> Checking back on this, whether it has been reviewed and if so, any comments.

Please see Dave's comments down-thread, there are apparently still
some unaddressed concerns.  If you'd like to do a V4 I think this
would be nice to get in.

-Eric

> On Wed, Sep 26, 2012 at 12:26 PM,  <raghu.prabhu13@gmail.com> wrote:
>> From: Raghavendra D Prabhu <rprabhu@wnohang.net>
>>
>> Currently, when there are no free inodes left / free space to allocate them (usually
>> without inode64), there is no indication anywhere of this case, making it harder
>> to diagnose this case.
>>
>> Hence, this series prints the causes/reasons to kernel log in a ratelimited
>> manner, when such a situation arises.
>>
>> Regarding why it is printed at callee location instead at caller, it gives
>> greater granularity in expressing the precise reason and give more details, and
>> also some along the path are not ENOSPC (such in xfs_ialloc where ialloc_context is not NULL but
>> ino is) along with the fact that it (xfs_ialloc) is called at multiple sites, so to avoid duplication.
>>
>> Version 1: Initial series.
>> Version 2: Added ratelimited printing to xfs_message and used that.
>> Version 3: Kept the logic intact in few places, fixed the column requirement.
>>
>> Raghavendra D Prabhu (3):
>>   xfs: Add ratelimited printk for different alert levels
>>   xfs: Print error when xfs_ialloc_ag_select fails to find continuous
>>     free space.
>>   xfs: Print error when unable to allocate inodes or out of free
>>     inodes.
>>
>>  fs/xfs/xfs_ialloc.c  | 31 ++++++++++++++++++++++++++++---
>>  fs/xfs/xfs_linux.h   |  1 +
>>  fs/xfs/xfs_message.h | 26 ++++++++++++++++++++++++++
>>  3 files changed, 55 insertions(+), 3 deletions(-)
>>
>> --
>> 1.7.12.1
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2012-11-28  2:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  6:56 [PATCH v3 0/3] Print when ENOSPC due to lack of inodes raghu.prabhu13
     [not found] ` <cover.1348641483.git.rprabhu@wnohang.net>
2012-09-26  6:56   ` [PATCH v3 1/3] xfs: Add ratelimited printk for different alert levels raghu.prabhu13
2012-09-26  6:56     ` [v3 Repost] " Raghavendra D Prabhu
2012-10-26 13:15     ` [v3,1/3] " Rich Johnston
2012-10-28 22:05     ` [PATCH v3 1/3] " Dave Chinner
2013-03-27 14:26     ` [v3 Repost] " Rich Johnston
2013-04-05 18:32       ` Ben Myers
2012-09-26  6:56   ` [PATCH v3 2/3] xfs: Print error when xfs_ialloc_ag_select fails to find continuous free space raghu.prabhu13
2012-10-26 13:15     ` [v3, " Rich Johnston
2012-10-28 22:10     ` [PATCH v3 " Dave Chinner
2012-09-26  6:56   ` [PATCH v3 3/3] xfs: Print error when unable to allocate inodes or out of free inodes raghu.prabhu13
2012-10-26 13:15     ` [v3, " Rich Johnston
2012-10-28 23:21     ` [PATCH v3 " Dave Chinner
2012-10-24 20:56 ` [PATCH v3 0/3] Print when ENOSPC due to lack of inodes Raghavendra Prabhu
2012-10-25 15:23   ` Rich Johnston
2012-10-26 13:18   ` Rich Johnston
2012-10-28 22:05     ` Dave Chinner
2012-10-30 14:59       ` Ben Myers
2012-11-28  2:52   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B57C7E.40002@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=raghu.prabhu13@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.