diff for duplicates of <50B5AAB4.9010103@ti.com> diff --git a/a/1.txt b/N1/1.txt index 081487f..616abf6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ On Wednesday 28 November 2012 07:45 AM, Jon Hunter wrote: > the following compiler warning is observed. > > CC arch/arm/mach-omap2/timer.o -> arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ +> arch/arm/mach-omap2/timer.c:489:20: warning: ?realtime_counter_init? > defined but not used [-Wunused-function] > > Commit fa6d79d also introduced the kernel configuration option @@ -53,7 +53,7 @@ the kernel configuration option CONFIG_SOC_OMAP5 is not selected then the following compiler warning is observed. CC arch/arm/mach-omap2/timer.o - arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ + arch/arm/mach-omap2/timer.c:489:20: warning: ?realtime_counter_init? defined but not used [-Wunused-function] It is because of the stub init function which was added for the cases @@ -91,3 +91,18 @@ index 69e4663..79d8e6b 100644 #define OMAP_SYS_TIMER_INIT(name, clkev_nr, clkev_src, \ -- 1.7.9.5 + + + + + + + + +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: 0001-ARM-OMAP2-Fix-realtime_counter_init-warning-in-timer.patch +Type: text/x-patch +Size: 1797 bytes +Desc: not available +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121128/18a565d1/attachment-0001.bin> diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index cf75bb8..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,6 +0,0 @@ -Content-Type: text/x-patch; - name="0001-ARM-OMAP2-Fix-realtime_counter_init-warning-in-timer.patch" -Content-Transfer-Encoding: 8bit -Content-Disposition: attachment; - filename*0="0001-ARM-OMAP2-Fix-realtime_counter_init-warning-in-timer.pa"; - filename*1="tch" diff --git a/a/2.txt b/a/2.txt deleted file mode 100644 index 44edf46..0000000 --- a/a/2.txt +++ /dev/null @@ -1,51 +0,0 @@ ->From e000aa13e47e29fbe3473bfd0277cb057c3160cc Mon Sep 17 00:00:00 2001 -From: Santosh Shilimkar <santosh.shilimkar@ti.com> -Date: Wed, 28 Nov 2012 11:28:57 +0530 -Subject: [PATCH] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time -counter), the function realtime_counter_init() was added. However, if -the kernel configuration option CONFIG_SOC_OMAP5 is not selected then -the following compiler warning is observed. - - CC arch/arm/mach-omap2/timer.o - arch/arm/mach-omap2/timer.c:489:20: warning: ‘realtime_counter_init’ - defined but not used [-Wunused-function] - -It is because of the stub init function which was added for the cases -where realtime_counter_init() is called with !CONFIG_SOC_HAS_REALTIME_COUNTER. -This is actually not necessary since the SOC which need this feature -will explicitly select the configuration. - -So just drop the unused stub to avoid the build warning. - -Patch is made after seeing Jon's patch which was wrapping the -real-time counter code under needed SOC #ifdef - -Cc: Jon Hunter <jon-hunter@ti.com> - -Reported-by: Tony Lindgren <tony@atomide.com> -Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> ---- - arch/arm/mach-omap2/timer.c | 3 --- - 1 file changed, 3 deletions(-) - -diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c -index 69e4663..79d8e6b 100644 ---- a/arch/arm/mach-omap2/timer.c -+++ b/arch/arm/mach-omap2/timer.c -@@ -428,9 +428,6 @@ static void __init realtime_counter_init(void) - - iounmap(base); - } --#else --static inline void __init realtime_counter_init(void) --{} - #endif - - #define OMAP_SYS_TIMER_INIT(name, clkev_nr, clkev_src, \ --- -1.7.9.5 diff --git a/a/content_digest b/N1/content_digest index bdd876d..28efa7b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,10 @@ "ref\01354068915-3378-1-git-send-email-jon-hunter@ti.com\0" "ref\01354068915-3378-2-git-send-email-jon-hunter@ti.com\0" - "From\0Santosh Shilimkar <santosh.shilimkar@ti.com>\0" - "Subject\0Re: [PATCH 1/3] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c\0" + "From\0santosh.shilimkar@ti.com (Santosh Shilimkar)\0" + "Subject\0[PATCH 1/3] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c\0" "Date\0Wed, 28 Nov 2012 11:39:56 +0530\0" - "To\0Jon Hunter <jon-hunter@ti.com>\0" - "Cc\0Tony Lindgren <tony@atomide.com>" - linux-omap <linux-omap@vger.kernel.org> - " linux-arm <linux-arm-kernel@lists.infradead.org>\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On Wednesday 28 November 2012 07:45 AM, Jon Hunter wrote:\n" "> In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time\n" @@ -16,7 +13,7 @@ "> the following compiler warning is observed.\n" ">\n" "> CC arch/arm/mach-omap2/timer.o\n" - "> arch/arm/mach-omap2/timer.c:489:20: warning: \342\200\230realtime_counter_init\342\200\231\n" + "> arch/arm/mach-omap2/timer.c:489:20: warning: ?realtime_counter_init?\n" "> defined but not used [-Wunused-function]\n" ">\n" "> Commit fa6d79d also introduced the kernel configuration option\n" @@ -64,7 +61,7 @@ "the following compiler warning is observed.\n" "\n" " CC arch/arm/mach-omap2/timer.o\n" - " arch/arm/mach-omap2/timer.c:489:20: warning: \342\200\230realtime_counter_init\342\200\231\n" + " arch/arm/mach-omap2/timer.c:489:20: warning: ?realtime_counter_init?\n" " defined but not used [-Wunused-function]\n" "\n" "It is because of the stub init function which was added for the cases\n" @@ -101,60 +98,21 @@ "\n" " #define OMAP_SYS_TIMER_INIT(name, clkev_nr, clkev_src,\t\t\t\\\n" "-- \n" - 1.7.9.5 - "\01:2\0" - "fn\00001-ARM-OMAP2-Fix-realtime_counter_init-warning-in-timer.patch\0" - "b\0" - ">From e000aa13e47e29fbe3473bfd0277cb057c3160cc Mon Sep 17 00:00:00 2001\n" - "From: Santosh Shilimkar <santosh.shilimkar@ti.com>\n" - "Date: Wed, 28 Nov 2012 11:28:57 +0530\n" - "Subject: [PATCH] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c\n" - "MIME-Version: 1.0\n" - "Content-Type: text/plain; charset=UTF-8\n" - "Content-Transfer-Encoding: 8bit\n" + "1.7.9.5\n" "\n" - "In commit fa6d79d (ARM: OMAP: Add initialisation for the real-time\n" - "counter), the function realtime_counter_init() was added. However, if\n" - "the kernel configuration option CONFIG_SOC_OMAP5 is not selected then\n" - "the following compiler warning is observed.\n" "\n" - " CC arch/arm/mach-omap2/timer.o\n" - " arch/arm/mach-omap2/timer.c:489:20: warning: \342\200\230realtime_counter_init\342\200\231\n" - " defined but not used [-Wunused-function]\n" "\n" - "It is because of the stub init function which was added for the cases\n" - "where realtime_counter_init() is called with !CONFIG_SOC_HAS_REALTIME_COUNTER.\n" - "This is actually not necessary since the SOC which need this feature\n" - "will explicitly select the configuration.\n" "\n" - "So just drop the unused stub to avoid the build warning.\n" "\n" - "Patch is made after seeing Jon's patch which was wrapping the\n" - "real-time counter code under needed SOC #ifdef\n" "\n" - "Cc: Jon Hunter <jon-hunter@ti.com>\n" "\n" - "Reported-by: Tony Lindgren <tony@atomide.com>\n" - "Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>\n" - "---\n" - " arch/arm/mach-omap2/timer.c | 3 ---\n" - " 1 file changed, 3 deletions(-)\n" "\n" - "diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c\n" - "index 69e4663..79d8e6b 100644\n" - "--- a/arch/arm/mach-omap2/timer.c\n" - "+++ b/arch/arm/mach-omap2/timer.c\n" - "@@ -428,9 +428,6 @@ static void __init realtime_counter_init(void)\n" - " \n" - " \tiounmap(base);\n" - " }\n" - "-#else\n" - "-static inline void __init realtime_counter_init(void)\n" - "-{}\n" - " #endif\n" - " \n" - " #define OMAP_SYS_TIMER_INIT(name, clkev_nr, clkev_src,\t\t\t\\\n" - "-- \n" - 1.7.9.5 + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: 0001-ARM-OMAP2-Fix-realtime_counter_init-warning-in-timer.patch\n" + "Type: text/x-patch\n" + "Size: 1797 bytes\n" + "Desc: not available\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121128/18a565d1/attachment-0001.bin> -edbfc35ec4466c694a9592a12ad29f23af63504c5623eddfbf56b7723724c383 +b0a96af4fa073442c974d9a34ed2f139797640b223a69f1f31db1d9e4751e31f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.