From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tdeaf-0008JD-6W
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 05:10:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TdeaZ-0003b9-Bq
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 05:10:01 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:42446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TdeaZ-0003ay-62
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 05:09:55 -0500
Received: by mail-pa0-f45.google.com with SMTP id bg2so6748883pad.4
	for <qemu-devel@nongnu.org>; Wed, 28 Nov 2012 02:09:54 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50B5E2EA.1010708@redhat.com>
Date: Wed, 28 Nov 2012 11:09:46 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1354094762-9538-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1354094762-9538-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: build vscclient from root only
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

Il 28/11/2012 10:26, Alon Levy ha scritto:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  libcacard/Makefile | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 7bce286..98c971d 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -1,3 +1,7 @@
> +ifeq ($(BUILD_DIR),)
> +	BUILD_DIR=$(CURDIR)/../
> +endif
> +
>  -include ../config-host.mak
>  -include $(SRC_PATH)/rules.mak
>  -include $(SRC_PATH)/Makefile.objs
> @@ -49,12 +53,12 @@ libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
>  
>  .PHONY: install-libcacard
>  
> -install-libcacard: libcacard.pc libcacard.la vscclient
> +install-libcacard: libcacard.pc libcacard.la ../vscclient
>  	$(INSTALL_DIR) "$(DESTDIR)$(libdir)"
>  	$(INSTALL_DIR) "$(DESTDIR)$(libdir)/pkgconfig"
>  	$(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
>  	$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> -	$(LIBTOOL) --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> +	$(LIBTOOL) --mode=install $(INSTALL_PROG) ../vscclient "$(DESTDIR)$(bindir)"
>  	$(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
>  	$(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
>  	for inc in *.h; do \
> 

Can you instead move all the vscclient rules to libcacard/Makefile
(including building the program as libcacard/vscclient)?

Paolo