From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, viresh.linux@gmail.com
Subject: Re: [PATCH v2] pata_arasan_cf: declare/use more local variables in arasan_cf_dma_start()
Date: Wed, 28 Nov 2012 12:42:47 -0500 [thread overview]
Message-ID: <50B64D17.8040706@pobox.com> (raw)
In-Reply-To: <201211011828.36550.sshtylyov@ru.mvista.com>
On 11/01/2012 11:28 AM, Sergei Shtylyov wrote:
> 'acdev->qc', 'acdev->qc->ap', and 'acdev->qc->tf' expressions are used multiple
> times in this function, so it makes sense to use the local variables for them.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> ---
> The patch is atop of the 'upstream' branch of libata-dev.git...
>
> drivers/ata/pata_arasan_cf.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
applied
prev parent reply other threads:[~2012-11-28 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 15:28 [PATCH v2] pata_arasan_cf: declare/use more local variables in arasan_cf_dma_start() Sergei Shtylyov
2012-11-01 14:31 ` viresh kumar
2012-11-28 17:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B64D17.8040706@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.