All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma
	(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jim Schutt <jaschut-4OHPYypu0djtX7QSmKvirg@public.gmane.org>
Subject: [PATCH 8/8] opensm/osm_torus.c: Minor simplification to check_qos_config
Date: Wed, 28 Nov 2012 14:03:44 -0500	[thread overview]
Message-ID: <50B66010.2000307@dev.mellanox.co.il> (raw)


Eliminate unneeded argument from check_qos_config
and rename to check_qos_swe_config

Signed-off-by: Jim Schutt <jaschut-4OHPYypu0djtX7QSmKvirg@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 opensm/osm_torus.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/opensm/osm_torus.c b/opensm/osm_torus.c
index b2a8832..43343c7 100644
--- a/opensm/osm_torus.c
+++ b/opensm/osm_torus.c
@@ -9304,8 +9304,8 @@ void check_vlarb_config(const char *vlarb_str, bool is_default,
  * Use this to check the qos_config for switch external ports.
  */
 static
-void check_qos_config(osm_qos_options_t *opt, osm_qos_options_t *def,
-		      const char *str, osm_log_t *log)
+void check_qos_swe_config(osm_qos_options_t *opt,
+			  osm_qos_options_t *def, osm_log_t *log)
 {
 	const char *vlarb_str, *tstr;
 	bool is_default;
@@ -9319,7 +9319,7 @@ void check_qos_config(osm_qos_options_t *opt, osm_qos_options_t *def,
 		OSM_LOG(log, OSM_LOG_INFO,
 			"Warning: full torus-2QoS functionality not available "
 			"for configured %s_max_vls = %d\n",
-			(opt->max_vls > 0 ? str : "qos"), opt->max_vls);
+			(opt->max_vls > 0 ? "qos_swe" : "qos"), opt->max_vls);
 
 	vlarb_str = opt->vlarb_high;
 	is_default = false;
@@ -9350,7 +9350,7 @@ void check_qos_config(osm_qos_options_t *opt, osm_qos_options_t *def,
 	if (opt->sl2vl)
 		OSM_LOG(log, OSM_LOG_INFO,
 			"Warning: torus-2QoS must override configured "
-			"%s_sl2vl to generate deadlock-free routes\n", str);
+			"qos_swe_sl2vl to generate deadlock-free routes\n");
 }
 
 static
@@ -9518,8 +9518,8 @@ out:
 			teardown_torus(ctx->torus);
 		ctx->torus = torus;
 
-		check_qos_config(&opt->qos_swe_options,
-				 &opt->qos_options, "qos_swe", log);
+		check_qos_swe_config(&opt->qos_swe_options, &opt->qos_options,
+				     log);
 
 		check_qos_ep_config(&opt->qos_ca_options,
 				    &opt->qos_options, "qos_ca", log);
-- 
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2012-11-28 19:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B66010.2000307@dev.mellanox.co.il \
    --to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=jaschut-4OHPYypu0djtX7QSmKvirg@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.