All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Jonathan Bohren <jonathan.bohren@gmail.com>
Cc: Simon Leonard <simon.v.leonard@gmail.com>, xenomai@xenomai.org
Subject: Re: [Xenomai] RTDM and PEAK PCIe
Date: Wed, 28 Nov 2012 20:10:18 +0100	[thread overview]
Message-ID: <50B6619A.10300@grandegger.com> (raw)
In-Reply-To: <CADy-PFjLCRbPc8MuYYsqEoEPXOuWNurzoG6nKaZFF_2+hQUoEw@mail.gmail.com>

On 11/27/2012 06:08 PM, Jonathan Bohren wrote:
> On Tue, Nov 27, 2012 at 11:51 AM, Wolfgang Grandegger <wg@grandegger.com> wrote:
>> On 11/27/2012 03:33 PM, Jonathan Bohren wrote:
>>> Wolfgang,
>>>
>>> I got the PEAK PCAN-003027 card working yesterday, but it required
>>> adding the device ID (0x0003 in addition to 0x0001) to the module
>>> device table `peak_pci_tbl` here:
>>> http://git.xenomai.org/?p=xenomai-2.6.git;a=blob;f=ksrc/drivers/can/sja1000/rtcan_peak_pci.c;h=53c8fef71d6d9e71dce6001941cb5922f6c977d6;hb=HEAD#l79
>>>
>>> I've committed my changes to a fork on github under the branch name
>>> "feature_peak_pcie" here:
>>> https://github.com/jbohren-forks/xenomai/compare/feature_peak_pcie
>>>
>>> Is this the appropriate channel to make a pull request, or should I do
>>> that somewhere else?
>>
>> Just post the patch here on this mailing list.
>>
>> Wolfgang.
>>
> 
> 
> Here you go:
> 
> 
>>From d97ee63e108c3f6eff26368af0df3ba1d1050692 Mon Sep 17 00:00:00 2001
> From: Jonathan Bohren <jbo@jhu.edu>
> Date: Tue, 27 Nov 2012 09:13:11 -0500
> Subject: [PATCH] Adding device ID for PEAK PCIe card IPEH-003027

Thanks, just your Signed-off-by is missing.

Wolfgang.



  reply	other threads:[~2012-11-28 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01 17:27 [Xenomai] RTDM and PEAK PCIe Jonathan Bohren
2012-10-01 18:42 ` Wolfgang Grandegger
2012-10-01 19:27   ` Jonathan Bohren
2012-11-27 14:33     ` Jonathan Bohren
2012-11-27 16:51       ` Wolfgang Grandegger
2012-11-27 17:08         ` Jonathan Bohren
2012-11-28 19:10           ` Wolfgang Grandegger [this message]
     [not found]             ` <CADy-PFjz_CeJ7-RC8xfr5PLrMcKH6sFTJP56z4ULKL8sS_q-VA@mail.gmail.com>
     [not found]               ` <CADy-PFitssGjMPVhWi5bCPHDMqvNPxvyZE68J0QjyLL4pwMd8A@mail.gmail.com>
2012-12-03  8:35                 ` Wolfgang Grandegger
2012-12-03 15:43               ` Jonathan Bohren
2012-12-04 13:22                 ` Wolfgang Grandegger
2012-12-04 15:02                   ` Jonathan Bohren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B6619A.10300@grandegger.com \
    --to=wg@grandegger.com \
    --cc=jonathan.bohren@gmail.com \
    --cc=simon.v.leonard@gmail.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.