From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] tegra: only define TEGRA_DEVICE_SETTINGS if not already defined
Date: Wed, 28 Nov 2012 14:03:02 -0700 [thread overview]
Message-ID: <50B67C06.5050300@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0yr-RpA_87St_WDR3nN2-FmiGMwuz3zpBXpgUArp5Znw@mail.gmail.com>
On 11/28/2012 02:01 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Wed, Nov 28, 2012 at 9:50 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> seaboard.h attempts to undefine TEGRA_DEVICE_SETTINGS and provide a
>> custom value. This worked when the "pre" included tegra20-common.h
>> provided the default. However, changes in the main U-Boot repo removed
>> this default from the "pre" included tegra20-common.h to the "post"
>> included tegra-common-post.h, which uncondtionally provides the value.
>> This causes the following compile warnings:
>>
>> In file included from /home/swarren/shared/git_wa/u-boot/include/configs/seaboard.h:129:0,
>> from /home/swarren/shared/git_wa/u-boot/include/config.h:10,
>> from /home/swarren/shared/git_wa/u-boot/include/common.h:37,
>> from lib/asm-offsets.c:18:
>> /home/swarren/shared/git_wa/u-boot/include/configs/tegra-common-post.h:163:0: warning: "TEGRA_DEVICE_SETTINGS" redefined
>> /home/swarren/shared/git_wa/u-boot/include/configs/seaboard.h:110:0: note: this is the location of the previous definition
>>
>> Solve this by modifying tegra-common-post.h to only provide a value for
>> TEGRA_DEVICE_SETTINGS if the board-specific header has not already
>> provided a custom value.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> These series doesn't apply to u-boot-tegra/master or /next for me, and
> the last one doesn't seem to apply to u-boot/master either. Can you
> please take a look, may be a timing issue.
Yes, as I mentioned this problem will only exist once u-boot/master and
u-boot-arm/master are merged together, so this patch series applies to
the result of the merge, which will be (at least part of) the state of
u-boot-tegra/* at some unspecified future time:-)
next prev parent reply other threads:[~2012-11-28 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 17:50 [U-Boot] [PATCH 1/3] tegra: only define TEGRA_DEVICE_SETTINGS if not already defined Stephen Warren
2012-11-28 17:50 ` [U-Boot] [PATCH 2/3] tegra: add LCD into default TEGRA_DEVICE_SETTINGS Stephen Warren
2012-11-28 17:50 ` [U-Boot] [PATCH 3/3] tegra: seaboard: remove custom TEGRA_DEVICE_SETTINGS Stephen Warren
2012-11-28 21:01 ` [U-Boot] [PATCH 1/3] tegra: only define TEGRA_DEVICE_SETTINGS if not already defined Simon Glass
2012-11-28 21:03 ` Stephen Warren [this message]
2012-11-28 21:15 ` Simon Glass
2012-11-29 18:40 ` Tom Warren
2012-11-29 19:10 ` Stephen Warren
2012-11-29 19:50 ` Tom Warren
2012-11-29 19:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B67C06.5050300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.