From: Thomas Hellstrom <thomas@shipmail.org>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: do not try to preserve caching state
Date: Wed, 28 Nov 2012 23:18:32 +0100 [thread overview]
Message-ID: <50B68DB8.60409@shipmail.org> (raw)
In-Reply-To: <CAH3drwb4nONcc1PHqsaEH4Vxm9ObyJ3o17ZQue=Y4TWJzQNMAg@mail.gmail.com>
On 11/28/2012 09:09 PM, Jerome Glisse wrote:
> On Wed, Nov 28, 2012 at 10:05 AM, <j.glisse@gmail.com> wrote:
>> From: Jerome Glisse <jglisse@redhat.com>
>>
>> It make no sense to preserve caching state especialy when
>> moving from vram to system. It burden the page allocator to
>> match the vram caching (often WC) which just burn CPU cycle
>> for no good reasons.
Nack.
This is a driver problem.
What happens with this patch if you evict write-combined TT memory to
system?
That's why we want to preserve caching state in the first place.
If you need a different behavior, you can fine-tune in
driver::evict_flags, or in the
radeon-case in radeon_move_ram_vram / radeon_move_vram_ram.
/Thomas
next prev parent reply other threads:[~2012-11-28 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 15:05 [PATCH] drm/ttm: do not try to preserve caching state j.glisse
2012-11-28 20:09 ` Jerome Glisse
2012-11-28 22:18 ` Thomas Hellstrom [this message]
2012-11-28 23:13 ` Jerome Glisse
2012-11-28 23:25 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B68DB8.60409@shipmail.org \
--to=thomas@shipmail.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
--cc=jglisse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.