All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] fdt: Correct global_data condition in main
Date: Wed, 28 Nov 2012 20:08:39 -0500	[thread overview]
Message-ID: <50B6B597.1070907@gmail.com> (raw)
In-Reply-To: <1354125298-13048-1-git-send-email-sjg@chromium.org>

Hi Simon,

On 11/28/2012 12:54 PM, Simon Glass wrote:
> We need an extra condition here in case we want to use fdt without the
> silent console/cmdline editing/post options. It is easier to just remove
> the #ifdef.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Remove the #ifdef as it is getting out of hand
> 
>  common/main.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/common/main.c b/common/main.c
> index 8052d42..5362781 100644
> --- a/common/main.c
> +++ b/common/main.c
> @@ -53,9 +53,7 @@
>  #include <linux/ctype.h>
>  #include <menu.h>
>  
> -#if defined(CONFIG_SILENT_CONSOLE) || defined(CONFIG_POST) || defined(CONFIG_CMDLINE_EDITING)
>  DECLARE_GLOBAL_DATA_PTR;
> -#endif
>  
>  /*
>   * Board-specific Platform code can reimplement show_boot_progress () if needed
> 

Applied to u-boot-fdt, pull request coming.

Thanks,
gvb

      reply	other threads:[~2012-11-29  1:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 15:25 [U-Boot] [PATCH] fdt: Correct global_data condition in main Simon Glass
2012-11-28 16:06 ` Wolfgang Denk
2012-11-28 16:59   ` Tom Rini
2012-11-28 17:54 ` [U-Boot] [PATCH v2] " Simon Glass
2012-11-29  1:08   ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B6B597.1070907@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.