From: Stephen Warren <swarren@wwwdotorg.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Simon <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [RFC][PATCH 2/2] ASoC: simple-card: add DT support
Date: Wed, 28 Nov 2012 22:20:14 -0700 [thread overview]
Message-ID: <50B6F08E.8040700@wwwdotorg.org> (raw)
In-Reply-To: <87r4ndhvwj.wl%kuninori.morimoto.gx@renesas.com>
On 11/28/2012 09:32 PM, Kuninori Morimoto wrote:
This could benefit from a patch description.
A file in Documentation/devicetree/bindings is required to specify the
format of the device tree.
Property name prefixes such as "cinfo," aren't very descriptive; what
does that mean?
A property name prefix such as "asoc," sounds Linux- (ASoC-) specific;
DT is supposed to represent HW, and hence shouldn't be influenced by OS
naming, etc.
Looking at the code, I think the machine driver is binding to the other
components by string name. With DT, it should be using phandles to point
at them instead.
The sysclk value that's parsed from DT doesn't appear to be used. How
does clocking work with this driver; what about when the sample-rate
changes, etc.?
next prev parent reply other threads:[~2012-11-29 5:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 4:31 [RFC][PATCH 0/2] ASoC: add DT support on simple-card Kuninori Morimoto
2012-11-29 4:31 ` [RFC][PATCH 1/2] ASoC: add snd_soc_of_parse_daifmt() Kuninori Morimoto
2012-11-29 5:21 ` Stephen Warren
2012-11-29 15:12 ` Mark Brown
2012-11-30 0:35 ` Kuninori Morimoto
2012-12-04 20:18 ` Stephen Warren
2012-12-05 7:55 ` Kuninori Morimoto
2012-12-05 20:42 ` Stephen Warren
2012-12-06 9:02 ` Kuninori Morimoto
2012-11-29 4:32 ` [RFC][PATCH 2/2] ASoC: simple-card: add DT support Kuninori Morimoto
2012-11-29 5:20 ` Stephen Warren [this message]
2012-11-29 6:05 ` Kuninori Morimoto
2012-11-30 10:38 ` Daniel Mack
2012-12-03 0:18 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B6F08E.8040700@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.