From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com
Subject: Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement
Date: Thu, 29 Nov 2012 09:47:49 +0100 [thread overview]
Message-ID: <50B72135.6050807@redhat.com> (raw)
In-Reply-To: <50B6FFC5.1080401@linux.vnet.ibm.com>
Il 29/11/2012 07:25, Wenchao Xia ha scritto:
>>
>> How can this be called with libqb_global_data.init_flag == 1?
>>
> OK, I will remove the if, but keep init_flag which can show
> library is already initialized.
Please remove it if there is no usage elsewhere.
For debugging, qemu_aio_context != NULL is just as good to check for
initialization.
Paolo
next prev parent reply other threads:[~2012-11-29 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 8:55 [Qemu-devel] [PATCH V12 0/7] libqblock qemu block layer library Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 1/7] Build system clean tests directory clearly Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 2/7] block export function path_has_protocol Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 3/7] stubs add function qemu_set_fd_handler Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 4/7] libqblock build system Wenchao Xia
2012-11-28 9:26 ` Paolo Bonzini
2012-11-29 6:28 ` Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 5/7] libqblock API design and type defines Wenchao Xia
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 6/7] libqblock API implement Wenchao Xia
2012-11-28 9:17 ` Paolo Bonzini
2012-11-29 6:25 ` Wenchao Xia
2012-11-29 8:47 ` Paolo Bonzini [this message]
2012-11-28 8:55 ` [Qemu-devel] [PATCH V12 7/7] libqblock test example Wenchao Xia
2012-11-28 9:17 ` Paolo Bonzini
2012-11-29 6:27 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B72135.6050807@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.