Re: [PATCH 2 of 2] xl: Accept a list for usbdevice in config file

[George Dunlap <george.dunlap@eu.citrix.com>]

On 29/11/12 11:06, Ian Campbell wrote:
> On Wed, 2012-11-28 at 16:52 +0000, George Dunlap wrote:
>> On Wed, Nov 28, 2012 at 3:11 PM, Pasi Kärkkäinen <pasik@iki.fi> wrote:
>>          On Wed, Nov 28, 2012 at 12:16:06PM +0000, George Dunlap wrote:
>>          > # HG changeset patch
>>          > # User George Dunlap <george.dunlap@eu.citrix.com>
>>          > # Date 1354104851 0
>>          > # Node ID e87d8fad28e00090591b65b2682dea9112f8830d
>>          > # Parent  538d9ffbd71b41e8cf6d7da0ded9e0a0b07f3c0d
>>          > xl: Accept a list for usbdevice in config file
>>          >
>>          > Allow the "usbdevice" key to accept a list of USB devices,
>>          and pass
>>          > them in using the new usbdevice_list domain build element.
>>          >
>>          > For backwards compatibility, still accept singleton values.
>>          >
>>          > Also update the xl.cfg manpage, adding information about how
>>          to pass
>>          > through host devices.
>>          >
>>          > Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>          >
>>          > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
>>          > --- a/docs/man/xl.cfg.pod.5
>>          > +++ b/docs/man/xl.cfg.pod.5
>>          > @@ -1103,15 +1103,22 @@ device.
>>          >
>>          >  Enables or disables a USB bus in the guest.
>>          >
>>          
>>          
>>          Should we add "HVM" there ?
>>
>> I could make this say, "...in an HVM guest".  (I'll wait to see if I
>> get other comments before re-sending the patch.)
> FWIW other similar options simply begin the paragraph with "(HVM only)"
>
> But actually this particular option is already underneath a section
> which begins "The following options apply only to HVM guests." and we
> don't seem to reiterate that in the other options.

Ah, right -- now I remember, I thought about it, saw that it was in an 
"HVM only" section, and decided that was sufficient. :-)

>
>>          > -=item B<usbdevice=DEVICE>
>>          > +=item B<usbdevice=[ "DEVICE", "DEVICE", ...]>
>>          >
>>          > -Adds B<DEVICE> to the USB bus. The USB bus must also be
>>          enabled using
>>          > -B<usb=1>. The most common use for this option is
>>          B<usbdevice=tablet>
> Are there other non-host* options?

qemu.git/vl.c suggests other options might include, "disk:", "serial:", 
"net:" and "bt:"; other non-colon-including options include "keyboard", 
"mouse", "wacom-tablet", and "braile".

On the other hand, a number of these seem to require supplementary 
options to work well; e.g., network and bt (bluetooth) require one 
argument to hook up a USB device, and another option to say how it's 
connected to what.

It's also interesting to note that the KVM documentation doesnt' mention 
using "-usb" and "-usbdevice" at all -- they seem to prefer using 
"-device" to specify hubs &c.

But still, it might be useful to say that these are passed via 
"usbdevice" to the qemu command line, and so you can find more 
information on the qemu man page.

  -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel