From: Gary Thomas <gary@mlbassoc.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gstreamer: Fix plugin builds
Date: Thu, 29 Nov 2012 06:33:55 -0700 [thread overview]
Message-ID: <50B76443.9070203@mlbassoc.com> (raw)
In-Reply-To: <20121129132627.GG3477@jama.jama.net>
On 2012-11-29 06:26, Martin Jansa wrote:
> On Thu, Nov 29, 2012 at 06:06:09AM -0700, Gary Thomas wrote:
>> Not all gstreamer plugins have localized documentation trees.
>
> This change looks good, just curious, which plugins recipe does not have
> po subdirectory?
>
> Something outside oe-core? Because all 4 included in oe-core worked fine:
> meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb:require gst-plugins.inc
> meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb:require gst-plugins.inc
> meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb:require gst-plugins.inc
> meta/recipes-multimedia/gstreamer/gst-plugins-ugly_0.10.19.bb:require gst-plugins.inc
Yes, this is for a plugin I'm working on for meta-ti (gst-plugin-ducati)
>>
>> The commit
>> commit f50e2984d9411a059b86d6c158e9416fceb84c3d
>> Author: Martin Jansa <martin.jansa@gmail.com>
>> Date: Wed Nov 28 15:59:48 2012 +0100
>> breaks the build for such packages because the file "po/Makefile.in.in"
>> is not present.
>>
>> This change allows building without the po/ subdirectory.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> meta/recipes-multimedia/gstreamer/gst-plugins.inc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins.inc b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> index 07b26a3..fc9567a 100644
>> --- a/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> @@ -23,5 +23,7 @@ PACKAGES_DYNAMIC += "^${PN}-.*"
>> # ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in, but before configure is executed
>> # http://lists.linuxtogo.org/pipermail/openembedded-core/2012-November/032233.html
>> oe_runconf_prepend() {
>> - sed -i -e "1a\\" -e 'GETTEXT_PACKAGE = @GETTEXT_PACKAGE@' ${S}/po/Makefile.in.in
>> + if [ -e ${S}/po/Makefile.in.in ]; then
>> + sed -i -e "1a\\" -e 'GETTEXT_PACKAGE = @GETTEXT_PACKAGE@' ${S}/po/Makefile.in.in
>> + fi
>> }
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
prev parent reply other threads:[~2012-11-29 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:06 [PATCH] gstreamer: Fix plugin builds Gary Thomas
2012-11-29 13:26 ` Martin Jansa
2012-11-29 13:33 ` Gary Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B76443.9070203@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.