From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Fioravante Subject: Re: [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to stubdom/Makefile Date: Thu, 29 Nov 2012 08:54:13 -0500 Message-ID: <50B76905.90503@jhuapl.edu> References: <1353421272-24797-1-git-send-email-matthew.fioravante@jhuapl.edu> <1353421272-24797-3-git-send-email-matthew.fioravante@jhuapl.edu> <1353664797.13542.190.camel@zakaz.uk.xensource.com> <20663.18782.886504.606333@mariner.uk.xensource.com> <20663.18917.138256.303363@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7157780685854680839==" Return-path: In-Reply-To: <20663.18917.138256.303363@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org This is a cryptographically signed message in MIME format. --===============7157780685854680839== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms060708060305080101060604" This is a cryptographically signed message in MIME format. --------------ms060708060305080101060604 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable As annoying as it may be, I think having a configure script or something = similar is the only right answer. More hidden makefile variables and=20 hacks makes everything more complicated. Before the existence of the=20 configure script Xen's build system was a huge pain to work with. Its=20 still not perfect. So here are 2 proposals: Add a configure.ac to stubdom. I can whip up a simple one where you can=20 enable/disable specific stub domains. Other options could be setting the = fetch urls for the libraries. People can add more options later. Now if=20 people disable vtpm, the check for cmake goes away. Move /tools/configure.ac to /configure.ac. Use this configure script to=20 configure the entire build. /Makefile still exists and works with or=20 without configuring, to enable building of the hypervisor. If we don't want to do this now, then I vote to just make cmake a=20 dependency for Xen without adding messy conditional hacks. On 11/29/2012 06:41 AM, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required = libs to stubdom/Makefile"): >> I guess it would be possible to have an ad-hoc switch in Config.mk >> (say) but I'm not sure this is better than just adding cmake as a hard= >> dependency. > Although, can we have a manual y/n switch in Config.mk so that if > someone has trouble with this feature they can turn off the build ? > > Thanks, > Ian. --------------ms060708060305080101060604 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIDyjCC A8YwggMvoAMCAQICBD/xyf0wDQYJKoZIhvcNAQEFBQAwLzELMAkGA1UEBhMCVVMxDzANBgNV BAoTBkpIVUFQTDEPMA0GA1UECxMGQklTRENBMB4XDTEwMDYxMTE4MjIwNloXDTEzMDYxMTE4 NTIwNlowZjELMAkGA1UEBhMCVVMxDzANBgNVBAoTBkpIVUFQTDEPMA0GA1UECxMGUGVvcGxl MTUwFgYDVQQLEw9WUE5Hcm91cC1CSVNEQ0EwGwYDVQQDExRNYXR0aGV3IEUgRmlvcmF2YW50 ZTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAnpbwVSP6o1Nb5lcW7dd3yTo9iBJdi7qz 4nANOMFPK7JOy5npKN1iiousl28U/scUJES55gPwAWYJK3uVyQAsA4adgDKi5DoD1UHDQEwp bY7iHLJeq0NPr4BqYNqnCFPbE6HC8zSJrr4qKn+gVUQT39SIFqdiIPJwZL8FYTRQ/zsCAwEA AaOCAbYwggGyMAsGA1UdDwQEAwIHgDArBgNVHRAEJDAigA8yMDEwMDYxMTE4MjIwNlqBDzIw MTIwNzE3MjI1MjA2WjAbBg0rBgEEAbMlCwMBAQEBBAoWCGZpb3JhbWUxMBsGDSsGAQQBsyUL AwEBAQIEChIIMDAxMDQyNjEwWAYJYIZIAYb6ax4BBEsMSVRoZSBwcml2YXRlIGtleSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY2VydGlmaWNhdGUgbWF5IGhhdmUgYmVlbiBleHBvcnRlZC4w KAYDVR0RBCEwH4EdTWF0dGhldy5GaW9yYXZhbnRlQGpodWFwbC5lZHUwUgYDVR0fBEswSTBH oEWgQ6RBMD8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJU0RD QTEOMAwGA1UEAxMFQ1JMNTYwHwYDVR0jBBgwFoAUCDUpmxH52EU2CyWmF2EJMB1yqeswHQYD VR0OBBYEFO6LYxg6r9wHZ+zdQtBHn1dZ/YTNMAkGA1UdEwQCMAAwGQYJKoZIhvZ9B0EABAww ChsEVjcuMQMCBLAwDQYJKoZIhvcNAQEFBQADgYEAJO9HQh4YNChVLzuZqK5ARJARD8JoujGZ fdo75quvg2jXFQe2sEjvLnxJZgm/pv8fdZakq48CWwjYHKuvIp7sDjTEsQfo+y7SpN/N2NvJ WU5SqfK1VgYtNLRRoGJUB5Q1aZ+Dg95g3kqpyfpUMISJL8IKVLtJVfN4fggFVUYZ9wwxggGr MIIBpwIBATA3MC8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJ U0RDQQIEP/HJ/TAJBgUrDgMCGgUAoIHLMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJ KoZIhvcNAQkFMQ8XDTEyMTEyOTEzNTQxM1owIwYJKoZIhvcNAQkEMRYEFDRJOIwA9xnPWJJv BBzT97OiwECkMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAK BggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYI KoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEgYA9b+FtsmMcPvQOqkyc8QWpXpcsBq4VvUJS S3usqxLaWHUd7j06ofrdoiFOx83qXFuxnBBIH31pkttlvDnKGfXhmW4Eni+gtbely4KY39Os 1RB1tECDSDJwd5KJVBueQQ2K+Pd3iaVKF8OOvGS+EmmO2Dv7Ui57qeA+Oc3ao1HBrQAAAAAA AA== --------------ms060708060305080101060604-- --===============7157780685854680839== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7157780685854680839==--