Re: [Powertop] [PATCH] report: fixed crash when writing report to RO filesystem

[Chris Ferron <chris.e.ferron at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

On 11/28/2012 07:42 AM, Jaroslav Škarvada wrote:
> Signed-off-by: Jaroslav Škarvada <jskarvad(a)redhat.com>
> ---
>   src/report/report.cpp | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/src/report/report.cpp b/src/report/report.cpp
> index 51bc6a7..c018bb1 100644
> --- a/src/report/report.cpp
> +++ b/src/report/report.cpp
> @@ -183,13 +183,16 @@ void init_report_output(char *filename_str, int iterations)
>   
>   void finish_report_output(void)
>   {
> -	fprintf(stderr, _("PowerTOP outputing using base filename %s\n"), reportout.filename);
>   	if (reporttype == REPORT_OFF)
>   		return;
>   
>   	report.finish_report();
> -	fputs(report.get_result(), reportout.report_file);
> -	fdatasync(fileno(reportout.report_file));
> -	fclose(reportout.report_file);
> +	if (reportout.report_file)
> +	{
> +		fprintf(stderr, _("PowerTOP outputing using base filename %s\n"), reportout.filename);
> +		fputs(report.get_result(), reportout.report_file);
> +		fdatasync(fileno(reportout.report_file));
> +		fclose(reportout.report_file);
> +	}
>   	report.clear_result();
>   }
You patch has been merged.
Thank You
Chris