From: Rob Herring <robherring2@gmail.com>
To: Alexander Sverdlin <asv@sysgo.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
netdev@vger.kernel.org, Barry.Song@csr.com,
w.sang@pengutronix.de,
alexander sverdlin <alexander.sverdlin.ext@nsn.com>
Subject: Re: [PATCH 1/2] of_mdio: Honour "status=disabled" property of device
Date: Thu, 29 Nov 2012 11:12:02 -0600 [thread overview]
Message-ID: <50B79762.2040009@gmail.com> (raw)
In-Reply-To: <50B71290.2060200@sysgo.com>
On 11/29/2012 01:45 AM, Alexander Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
>
> of_mdio: Honour "status=disabled" property of device
>
> Currently of_mdiobus_register() function registers all PHY devices,
> independetly from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not pupulated. But such check for MDIO buses
> was missing until now. Fix it.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
> ---
Applied.
Rob
> --- linux.orig/drivers/of/of_mdio.c
> +++ linux/drivers/of/of_mdio.c
> @@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
> return rc;
>
> /* Loop over the child nodes and register a phy_device for each one */
> - for_each_child_of_node(np, child) {
> + for_each_available_child_of_node(np, child) {
> const __be32 *paddr;
> u32 addr;
> int len;
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
>
next prev parent reply other threads:[~2012-11-29 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 7:45 [PATCH 1/2] of_mdio: Honour "status=disabled" property of device Alexander Sverdlin
2012-11-29 17:12 ` Rob Herring [this message]
2012-11-29 17:36 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B79762.2040009@gmail.com \
--to=robherring2@gmail.com \
--cc=Barry.Song@csr.com \
--cc=alexander.sverdlin.ext@nsn.com \
--cc=asv@sysgo.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.