From: Andrew Gallatin <gallatin@myri.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH resend net-next 2/3] myri10ge: Add vlan rx for better GRO perf.
Date: Thu, 29 Nov 2012 14:19:30 -0500 [thread overview]
Message-ID: <50B7B542.6090804@myri.com> (raw)
In-Reply-To: <20121129.131738.1067398537384405805.davem@davemloft.net>
On 11/29/12 13:17, David Miller wrote:
> From: Andrew Gallatin <gallatin@myri.com>
> Date: Wed, 28 Nov 2012 16:20:56 -0500
>
>> + if ((dev->features & (NETIF_F_HW_VLAN_RX)) == NETIF_F_HW_VLAN_RX &&
>> + (veh->h_vlan_proto == ntohs(ETH_P_8021Q))) {
>> + /* fixup csum if needed */
>> + if (skb->ip_summed == CHECKSUM_COMPLETE)
>> + skb->csum = csum_sub(skb->csum,
>> + csum_partial(va + ETH_HLEN,
>> + VLAN_HLEN, 0));
>
> This indentation looks like spaghetti, verify that this kind of error
> doesn't exist in the rest of your patches, and resend the series.
>
Sorry. Emacs victim... I'll clean it up & re-submit. I'd stupidly
assumed that checkpatch would verify indentation. :(
Drew
next prev parent reply other threads:[~2012-11-29 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 21:20 [PATCH resend net-next 2/3] myri10ge: Add vlan rx for better GRO perf Andrew Gallatin
2012-11-29 18:17 ` David Miller
2012-11-29 19:19 ` Andrew Gallatin [this message]
2012-11-29 19:47 ` Joe Perches
2012-11-29 19:53 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B7B542.6090804@myri.com \
--to=gallatin@myri.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.