From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Gallatin Subject: [PATCH v3 net-next 0/2] myri10ge: LRO to GRO conversion Date: Thu, 29 Nov 2012 16:07:15 -0500 Message-ID: <50B7CE83.1020809@myri.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev To: David Miller Return-path: Received: from mail-gh0-f174.google.com ([209.85.160.174]:63251 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200Ab2K2VHT (ORCPT ); Thu, 29 Nov 2012 16:07:19 -0500 Received: by mail-gh0-f174.google.com with SMTP id g15so2603302ghb.19 for ; Thu, 29 Nov 2012 13:07:18 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Hi, The following patchset is a resubmission of '[PATCH resend net-next 0/3] myri10ge: LRO to GRO conversion', and converts myri10ge from using the old inet_lro interface to GRO, and to do vlan tag decap in the driver so as to not suffer a performance penalty for vlan tagged traffic due to the conversion. Changes this time are: - Clean up some messy indenting & parens in "2/3 myri10ge-Add-vlan-rx-for-better-GRO-perf" and store the vlan hdr csum in a variable, so now we are not calling csum_partial() nested so deeply it spreads across 3 lines - Folded 3/3 myri10ge-Use-skb_fill_page_desc into 1/3 myri10ge-Convert-from-LRO-to-GRO.patch since it is really just small part of the LRO removal cleanup. It was originally a separate patch because I noticed the cleanup at the last second, and was too lazy to fold it into the first patch where it belonged. Note that a naive LRO->GRO conversion of myri10ge will result in a performance regression for vlan tagged frames. This is because myri10ge does not offer hardware vlan tag offload, and because GRO requires hardware vlan tag offload to aggregate vlan tagged frames. To address this performance regression, I have implemented vlan tag popping in the myri10ge driver, as it seems to be the lesser of two evils. As eric.dumazet@gmail.com commented when I asked about this on netdev: "Given GRO assumes NIC does hardware vlan offloading, I guess I would chose to do that. It seems unfortunate to add vlan decap in GRO path, already very complex." Andrew Gallatin (2): myri10ge: Convert from LRO to GRO myri10ge: Add vlan rx for better GRO perf. drivers/net/ethernet/myricom/Kconfig | 1 - drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 275 ++++++---------------- 2 files changed, 74 insertions(+), 202 deletions(-)