From: Rob Clark <rob@ti.com>
To: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: gregkh@linuxfoundation.org, laurent.pinchart@ideasonboard.com,
devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
Enric Balletbo i Serra <eballetbo@iseebcn.com>
Subject: Re: [PATCH] staging: drm/omap: fix missing include on omap_crtc
Date: Thu, 29 Nov 2012 15:13:16 -0600 [thread overview]
Message-ID: <50B7CFEC.6040109@ti.com> (raw)
In-Reply-To: <1354107300-26619-1-git-send-email-eballetbo@gmail.com>
On 11/28/2012 06:55 AM, Enric Balletbo i Serra wrote:
> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
> This fixes following error:
>
> | ...
> | CC [M] drivers/staging/omapdrm/omap_crtc.o
> | .../omapdrm/omap_crtc.c:22:22: fatal error: drm_mode.h: No such file or directory
> | ...
fwiw, I have this patch in my local tree that is fixing the same issue:
https://patchwork.kernel.org/patch/1588461/
and I think I've seen at least one other patch for the same thing.. it
would be nice to at least get one version of this fix in 3.7..
BR,
-R
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> ---
> drivers/staging/omapdrm/omap_crtc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c
> index 732f2ad..1d54fe9 100644
> --- a/drivers/staging/omapdrm/omap_crtc.c
> +++ b/drivers/staging/omapdrm/omap_crtc.c
> @@ -17,9 +17,9 @@
> * this program. If not, see <http://www.gnu.org/licenses/>.
> */
>
> -#include "omap_drv.h"
> +#include <drm/drm_mode.h>
>
> -#include "drm_mode.h"
> +#include "omap_drv.h"
> #include "drm_crtc.h"
> #include "drm_crtc_helper.h"
>
next prev parent reply other threads:[~2012-11-29 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:55 [PATCH] staging: drm/omap: fix missing include on omap_crtc Enric Balletbo i Serra
2012-11-29 21:13 ` Rob Clark [this message]
2012-11-29 21:48 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B7CFEC.6040109@ti.com \
--to=rob@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=eballetbo@gmail.com \
--cc=eballetbo@iseebcn.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.