From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx191.postini.com [74.125.245.191]) by kanga.kvack.org (Postfix) with SMTP id BA73C6B0075 for ; Thu, 29 Nov 2012 23:10:55 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 4CA9E3EE0C1 for ; Fri, 30 Nov 2012 13:10:54 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2FDB745DEBC for ; Fri, 30 Nov 2012 13:10:54 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1810345DEBA for ; Fri, 30 Nov 2012 13:10:54 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id F1E751DB803C for ; Fri, 30 Nov 2012 13:10:53 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id A456C1DB8040 for ; Fri, 30 Nov 2012 13:10:53 +0900 (JST) Message-ID: <50B831BC.3050500@jp.fujitsu.com> Date: Fri, 30 Nov 2012 13:10:36 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [patch v2 5/6] memcg: further simplify mem_cgroup_iter References: <1353955671-14385-1-git-send-email-mhocko@suse.cz> <1353955671-14385-6-git-send-email-mhocko@suse.cz> In-Reply-To: <1353955671-14385-6-git-send-email-mhocko@suse.cz> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Ying Han , Tejun Heo , Glauber Costa , Li Zefan (2012/11/27 3:47), Michal Hocko wrote: > mem_cgroup_iter basically does two things currently. It takes care of > the house keeping (reference counting, raclaim cookie) and it iterates > through a hierarchy tree (by using cgroup generic tree walk). > The code would be much more easier to follow if we move the iteration > outside of the function (to __mem_cgrou_iter_next) so the distinction > is more clear. > This patch doesn't introduce any functional changes. > > Signed-off-by: Michal Hocko Very nice look ! Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755716Ab2K3EKz (ORCPT ); Thu, 29 Nov 2012 23:10:55 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38600 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753143Ab2K3EKy (ORCPT ); Thu, 29 Nov 2012 23:10:54 -0500 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.4 Message-ID: <50B831BC.3050500@jp.fujitsu.com> Date: Fri, 30 Nov 2012 13:10:36 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Michal Hocko CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Ying Han , Tejun Heo , Glauber Costa , Li Zefan Subject: Re: [patch v2 5/6] memcg: further simplify mem_cgroup_iter References: <1353955671-14385-1-git-send-email-mhocko@suse.cz> <1353955671-14385-6-git-send-email-mhocko@suse.cz> In-Reply-To: <1353955671-14385-6-git-send-email-mhocko@suse.cz> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/11/27 3:47), Michal Hocko wrote: > mem_cgroup_iter basically does two things currently. It takes care of > the house keeping (reference counting, raclaim cookie) and it iterates > through a hierarchy tree (by using cgroup generic tree walk). > The code would be much more easier to follow if we move the iteration > outside of the function (to __mem_cgrou_iter_next) so the distinction > is more clear. > This patch doesn't introduce any functional changes. > > Signed-off-by: Michal Hocko Very nice look ! Acked-by: KAMEZAWA Hiroyuki