All of lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [ARM] head.S change broke platform device registration?
Date: Fri, 30 Nov 2012 10:28:41 +0000	[thread overview]
Message-ID: <50B88A59.6070207@arm.com> (raw)
In-Reply-To: <CAHod+GdVobkgOj6bsFhn6qqLhysQoEzcDtAS05u1kPnssSfObg@mail.gmail.com>

On 30/11/12 01:38, Marko Kati? wrote:
> I recently tried to boot v3.7-rc7 on my akita (Sharp Zaurus C-1000,
> PXA270 machine).
> Backlight never turned on but the kernel booted just fine.
> After some investigation i determined that the gpio expander (max7310,
> i2c chip) is not even
> registered and thus not present in /sys/bus/i2c/devices.
> Backlight gpio controls are hooked to this chip thus, no backlight.
> 
> I thought that too many things could have caused this so i went
> straight to bisecting.
> Bisection pointed me to this commit:
> 
>  commit 424e5994e63326a42012f003f1174f3c363c7b62
> Author: Dave Martin <dave.martin@linaro.org>
> Date:   Fri Feb 10 18:07:07 2012 -0800
> 
>     ARM: zImage/virt: hyp mode entry support for the zImage loader
> 
>     The zImage loader needs to turn on the MMU in order to take
>     advantage of caching while decompressing the zImage.  Running this
>     in hyp mode would require the LPAE pagetable format to be
>     supported; to avoid this complexity, this patch switches out of hyp
>     mode, and returns back to hyp mode just before booting the kernel.
> 
>     This implementation assumes that the Hyp mode view of memory and the
>     PL1 view of memory are coherent, providing that the MMU and caches
>     are off in both, as required by the boot protocol.  The zImage
>     decompression code must drain the write buffer on completion anyway, and
>     entry into Hyp mode should flush any prefetch buffer, avoiding hazards
>     associated with local write buffers and the pipeline.
> 
>     Signed-off-by: Dave Martin <dave.martin@linaro.org>
>     Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> 
> This commit was merged in v3.7-rc1. And indeed, if i
> revert this single commit, my gpio expander reappears and
> so does my backlight.
> I made no other changes to the vanilla 3.7-rc7
> except this revert.
> 
> This seems very strange to me because i, with my limited knowledge,
> cannot see any correlation between this commit and the bug i am experiencing.
> 
> Does anyone know what exactly is happening here?

This is incredibly puzzling. I could understand your board not booting
at all because of this patch, but an i2c device missing?

Can you see the i2c controller at all? I'll try to dig my PXA270 board
and see if I can reproduce your issue.

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2012-11-30 10:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30  1:38 [ARM] head.S change broke platform device registration? Marko Katić
2012-11-30 10:28 ` Marc Zyngier [this message]
2012-11-30 12:20   ` Marko Katić
2012-11-30 13:45     ` Marc Zyngier
2012-11-30 14:34     ` Russell King - ARM Linux
2012-12-04 21:48       ` Marko Katić
2012-12-04 22:18         ` Russell King - ARM Linux
2012-12-05 22:18           ` Marko Katić
2012-12-05 23:58             ` Russell King - ARM Linux
2012-12-07 12:28               ` Russell King - ARM Linux
2012-12-07 13:49                 ` Dave Martin
2012-12-10 17:23                   ` Marko Katić
2012-12-10 17:31                     ` Dave Martin
2012-12-10 17:21               ` Marko Katić
2012-12-11  0:25                 ` Russell King - ARM Linux
2012-12-12 15:55                   ` Richard Purdie
2012-12-12 17:22                     ` Marko Katić
2012-12-12 17:59                     ` Russell King - ARM Linux
2012-12-12 22:29                       ` Richard Purdie
2012-11-30 12:17 ` Dave Martin
2012-11-30 12:28   ` Marko Katić
2012-11-30 12:40     ` Russell King - ARM Linux
2012-11-30 13:07       ` Marko Katić
2012-11-30 13:11         ` Marko Katić

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B88A59.6070207@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.