All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] flex: fix build for nommu systems
Date: Fri, 30 Nov 2012 07:36:00 -0300	[thread overview]
Message-ID: <50B88C10.6070007@zacarias.com.ar> (raw)
In-Reply-To: <50B7ED98.1030501@mind.be>

On 11/29/2012 08:19 PM, Arnout Vandecappelle wrote:
>  Two small comments.
> 
> [snip]
>> +ifeq ($(BR2_PACKAGE_FLEX_BINARY),)
> 
>  I would prefer to compare with y and swap the two branches
> (that will also make the diff much more readable...)

Sure, i left it that way because i was using another aproach before this
one (removing the binary option since it's pointless without a target
toolchain), but changed my mind after a little chat with Thomas.

>> +define FLEX_DISABLE_PROGRAM
>> +    $(SED) 's/^bin_PROGRAMS.*//' $(@D)/Makefile.in
>>   endef
>>
>> -define FLEX_UNINSTALL_LEX
>> -    -rm $(TARGET_DIR)/usr/bin/lex
>> -endef
>> +FLEX_POST_EXTRACT_HOOKS += FLEX_DISABLE_PROGRAM
> 
>  POST_PATCH_HOOKS would be more appropriate.

Really?
It's basically another patch, i can do it before (like now) it's patched
with something else or after.
If the other patches did too much damage so that the sed wouldn't work,
well, it'd probably be against buildroot policy on patches :)
Regards.

      reply	other threads:[~2012-11-30 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 14:35 [Buildroot] [PATCH] flex: fix build for nommu systems Gustavo Zacarias
2012-11-29 23:19 ` Arnout Vandecappelle
2012-11-30 10:36   ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B88C10.6070007@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.