Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

[Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>]

On 2012/11/30 20:42, Luiz Capitulino wrote:
> On Fri, 30 Nov 2012 15:25:57 +0900
> Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:
> 
>> Hi,
>>
>> This is version 5 of the qemu-ga fsfreeze hook patchset.
> 
> This series split is not good. You should squash patches 3/3 and 1/3 and
> rebase this series on top of:
> 
>  http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03016.html

I see, I will resend a patchset squashed and rebased on this.
BTW, is there a git branch for 1.4 anywhere?

> Also, please look at qmp_shutdown() and bios_supports_mode() for examples
> of command execution with improved error reporting.
> 
>> *Changes from v4: ( http://patchwork.ozlabs.org/patch/200924/ )
>>  1/3: Improve error messages when fsfreeze hook is not executable.
>>       Make fsfreeze-hook disabled by default, and enabled only if
>>       --fsfreeze-hook option is specified.
> 
> Let me clarify that there are two ways of doing this. One is the way above,
> the other way is to enable it by default but allow something like
> "--fsfreeze-hook no" to disable the hook execution.

I chose the way to disable it by default because it's more precise.
If we enable the hook by default, we need to guess whether the hook is
executed by its presence, and then the hook placed on wrong path will
not cause an error.

> Both ways are fine with me.
> 

Thanks,
-- 
Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory