From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeQUy-0008Qj-DN for qemu-devel@nongnu.org; Fri, 30 Nov 2012 08:19:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeQUr-0008NE-Sb for qemu-devel@nongnu.org; Fri, 30 Nov 2012 08:19:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeQUr-0008Lk-L8 for qemu-devel@nongnu.org; Fri, 30 Nov 2012 08:19:13 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAUDJCVw022491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Nov 2012 08:19:13 -0500 Message-ID: <50B8B24D.8010207@redhat.com> Date: Fri, 30 Nov 2012 14:19:09 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1354279929-568-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1354279929-568-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/6] block: bdrv_img_create(): propagate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Am 30.11.2012 13:52, schrieb Luiz Capitulino: > By adding error propagation to bdrv_img_create() we improve error reporting > in QMP and simplify qemu-img.c:img_create() a bit. > > o v3 > > - Update qmp_drive_mirror() > > o Patches changed: > > - 1/6 (changed) > - 5/6 (new patch) > > Luiz Capitulino (6): > block: bdrv_img_create(): add Error ** argument > qemu-img: img_create(): pass Error object to bdrv_img_create() > qemu-img: img_create(): drop unneeded goto and ret variable > qmp: qmp_transaction(): pass Error object to bdrv_img_create() > qmp: qmp_drive_mirror(): pass Error object to bdrv_img_create() > block: bdrv_img_create(): drop unused error handling code > > block.c | 60 +++++++++++++++++++++++++----------------------------------- > block.h | 6 +++--- > blockdev.c | 29 +++++++++++++++-------------- > qemu-img.c | 19 ++++++++++--------- > 4 files changed, 53 insertions(+), 61 deletions(-) Thanks, applied all to the block-next branch for 1.4. Kevin