From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] exofs: clean up the correct page collection on write
 error
Date: Fri, 30 Nov 2012 16:15:41 +0200
Message-ID: <50B8BF8D.8050704@panasas.com>
References: <1353941346-20598-1-git-send-email-idank@tonian.com> <50B8BE60.6090009@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: <linux-fsdevel@vger.kernel.org>, <osd-dev@open-osd.org>,
	<solo@tonian.com>, <bhalevy@tonian.com>, <ilya@tonian.com>
To: Idan Kedar <idank@tonian.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from natasha.panasas.com ([67.152.220.90]:35871 "EHLO
	natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758282Ab2K3OPu (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 30 Nov 2012 09:15:50 -0500
In-Reply-To: <50B8BE60.6090009@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 11/30/2012 04:10 PM, Boaz Harrosh wrote:
> On 11/26/2012 04:49 PM, Idan Kedar wrote:
>> if ore_write() fails, we would unlock the pages of pcol, which is now
>> empty, rather than pcol_copy which owns the pages when ore_write() is
>> called. this means that no pages will actually be unlocked
>> (pcol.nr_pages == 0) and the writing process (more accurately, the
>> syncing process) will hang waiting for a writeback notification that
>> never comes.
>>
>> moreover, if ore_write() fails, pcol_free() is called for pcol, whereas
>> pcol_copy is the object owning the ore_io_state, thus leaking the
>> ore_io_state.
>>
>> Signed-off-by: Idan Kedar <idank@tonian.com>
> 
> Thanks Idan, good catch.
> 
> I have simplified your patch a bit, see below. But basically it
> is all the same. Please check me out
> 

I forgot to ask do you need this for stable?

Boaz