From: Thomas Hellstrom <thellstrom@vmware.com>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/6] drm/ttm: lru lock atomicity removal
Date: Fri, 30 Nov 2012 16:59:16 +0100 [thread overview]
Message-ID: <50B8D7D4.2030805@vmware.com> (raw)
In-Reply-To: <50B8A254.904@canonical.com>
On 11/30/2012 01:11 PM, Maarten Lankhorst wrote:
> With all the previous patches there shouldn't be anything lying on the reservations being atomic
> with removal of the bo's from the lru lists any more.
>
> As such we can finally fix the locking primitives and make it act like normal mutex calls.
>
> Patch 1 is the actual removal of the guarantee in ttm_bo_reserve
> patch 2 is a cleanup of ttm_eu_backoff_reservation from removing that guarantee
> patch 3...6 are introducing ttm_bo_reserve_slowpath.
>
> After this series, this should directly map to my proposed extensions to mutex.
>
Maarten,
I'm going on parental leave next week and don't have time to review
these patches in detail for at least three weeks.
In principle I'm OK with the changes, introduced, though, but I guess we
need another reviewer to step up.
/Thomas
next prev parent reply other threads:[~2012-11-30 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 12:11 [PATCH 0/6] drm/ttm: lru lock atomicity removal Maarten Lankhorst
2012-11-30 12:12 ` [PATCH 1/6] drm/ttm: remove lru_lock around ttm_bo_reserve Maarten Lankhorst
2012-11-30 12:12 ` [PATCH 2/6] drm/ttm: cleanup ttm_eu_reserve_buffers handling Maarten Lankhorst
2012-11-30 12:12 ` [PATCH 3/6] drm/ttm: add ttm_bo_reserve_slowpath Maarten Lankhorst
2012-11-30 12:12 ` [PATCH 4/6] drm/ttm: use ttm_bo_reserve_slowpath_nolru in ttm_eu_reserve_buffers Maarten Lankhorst
2012-12-06 1:36 ` Jerome Glisse
2012-12-06 10:52 ` Maarten Lankhorst
2012-12-06 15:38 ` Jerome Glisse
2012-11-30 12:12 ` [PATCH 5/6] drm/nouveau: use ttm_bo_reserve_slowpath in validate_init Maarten Lankhorst
2012-11-30 12:13 ` [PATCH 6/6] drm/ttm: unexport ttm_bo_wait_unreserved Maarten Lankhorst
2012-12-06 1:19 ` [PATCH 1/6] drm/ttm: remove lru_lock around ttm_bo_reserve Jerome Glisse
2012-12-06 9:55 ` Maarten Lankhorst
2012-11-30 15:59 ` Thomas Hellstrom [this message]
2012-12-06 1:15 ` [PATCH 0/6] drm/ttm: lru lock atomicity removal Jerome Glisse
2012-12-06 1:38 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8D7D4.2030805@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.