From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fsck scratch device if it got used
Date: Fri, 30 Nov 2012 10:08:46 -0600 [thread overview]
Message-ID: <50B8DA0E.4000605@redhat.com> (raw)
In-Reply-To: <20121130160616.GD5667@infradead.org>
On 11/30/12 10:06 AM, Christoph Hellwig wrote:
> On Thu, Nov 29, 2012 at 12:59:55PM -0600, Eric Sandeen wrote:
>> This will cause the $SCRATCH_DEV to be fscked if it
>> was used in the prior test. Without this I don't
>> think it gets done unless specifically requested
>> by the test.
>
> This one looks good.
Hm now that I think of it perhaps I should remove the explicit _check_scratch-es if they happen at the end of the run, just to try to speed things up.
>> Also recreate lost+found/ in one test so that e2fsck
>> doesn't complain.
>
> This one I can't make any sense of. Care to send it separately with a
> good explanation?
>
Ok, sure.
Basically, test does an rm -rf of the scrach mnt, but e2fsck thinks that a missing lost+found/ is cause for complaint and a failure exit code, which then stops the tests :(
(hum, now that I think about it, maybe a broken scratch device shouldn't stop the test series, but should just log a test failure? What do you think?)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-30 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 18:59 [PATCH] xfstests: fsck scratch device if it got used Eric Sandeen
2012-11-30 16:06 ` Christoph Hellwig
2012-11-30 16:08 ` Eric Sandeen [this message]
2012-11-30 22:27 ` Dave Chinner
2012-11-30 22:29 ` Eric Sandeen
2012-12-03 14:03 ` Carlos Maiolino
2012-12-03 18:56 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8DA0E.4000605@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.