From: Jason Wessel <jason.wessel@windriver.com>
To: <Openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] populate_sdk_base.bbclass: make failure to find ld-linux.so a hard error
Date: Fri, 30 Nov 2012 14:10:53 -0600 [thread overview]
Message-ID: <50B912CD.8000802@windriver.com> (raw)
In-Reply-To: <1354304048-17216-1-git-send-email-jason.wessel@windriver.com>
On 11/30/2012 01:34 PM, Jason Wessel wrote:
> The shell archive that populates the external SDK should fail if it
> cannot find the ld-linux.so else it will corrupt all binaries because
> a random path will be used from the list of executables when dl_path
> is empty.
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
> meta/classes/populate_sdk_base.bbclass | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index ac34c32..73bd44d 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -176,6 +176,10 @@ done
> # fix dynamic loader paths in all ELF SDK binaries
> native_sysroot=$(cat $env_setup_script |grep OECORE_NATIVE_SYSROOT|cut -d'=' -f2|tr -d '"')
> dl_path=$(find $native_sysroot/lib -name "ld-linux*")
> +if [ "$dl_path" = "" ] ; then
> + echo "SDK could not be set up. Relocate script to find ld-linux.so. Abort!"
Ooops Should be.
+ echo "SDK could not be set up. Relocate script unable to find ld-linux.so. Abort!"
>
> + exit 1
> +fi
> executable_files=$(find $native_sysroot -type f -perm +111)
> ${env_setup_script%/*}/relocate_sdk.py $target_sdk_dir $dl_path $executable_files
> if [ $? -ne 0 ]; then
Jason.
prev parent reply other threads:[~2012-12-01 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 19:34 [PATCH] populate_sdk_base.bbclass: make failure to find ld-linux.so a hard error Jason Wessel
2012-11-30 20:10 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B912CD.8000802@windriver.com \
--to=jason.wessel@windriver.com \
--cc=Openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.