From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [Suggestion] drivers/tty: drivers/char/: for MAX_ASYNC_BUFFER_SIZE Date: Sat, 01 Dec 2012 17:01:04 +0800 Message-ID: <50B9C750.5050604@asianux.com> References: <50B6E751.9000000@asianux.com> <20121129051335.GA4375@kroah.com> <50B6F967.3050000@asianux.com> <20121129183207.GA4688@kroah.com> <50B81F76.8020508@asianux.com> <50B8DDAC.8070901@microgate.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from intranet.asianux.com ([58.214.24.6]:55461 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611Ab2LAJAO (ORCPT ); Sat, 1 Dec 2012 04:00:14 -0500 In-Reply-To: <50B8DDAC.8070901@microgate.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Paul Fulghum Cc: Greg KH , "linux-kernel@vger.kernel.org" , linux-serial@vger.kernel.org, Alan Cox =E4=BA=8E 2012=E5=B9=B412=E6=9C=8801=E6=97=A5 00:24, Paul Fulghum =E5=86= =99=E9=81=93: > My suggestion is to leave it as is for now until I can make > those changes. I admit the current code is ugly enough to > cause confusion (sorry Chen Gang), but I don't see any immediate dang= er. >=20 do not need 'sorry', learn with each other. (I am just learning through read kernel source code -- "code review") I am glad to know that my suggestion is useful (although it seems a minor suggestion). for me, it is enough. :-) thanks. --=20 Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894Ab2LAJAP (ORCPT ); Sat, 1 Dec 2012 04:00:15 -0500 Received: from intranet.asianux.com ([58.214.24.6]:55461 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611Ab2LAJAO (ORCPT ); Sat, 1 Dec 2012 04:00:14 -0500 X-Spam-Score: -100.8 Message-ID: <50B9C750.5050604@asianux.com> Date: Sat, 01 Dec 2012 17:01:04 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Paul Fulghum CC: Greg KH , "linux-kernel@vger.kernel.org" , linux-serial@vger.kernel.org, Alan Cox Subject: Re: [Suggestion] drivers/tty: drivers/char/: for MAX_ASYNC_BUFFER_SIZE References: <50B6E751.9000000@asianux.com> <20121129051335.GA4375@kroah.com> <50B6F967.3050000@asianux.com> <20121129183207.GA4688@kroah.com> <50B81F76.8020508@asianux.com> <50B8DDAC.8070901@microgate.com> In-Reply-To: <50B8DDAC.8070901@microgate.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2012年12月01日 00:24, Paul Fulghum 写道: > My suggestion is to leave it as is for now until I can make > those changes. I admit the current code is ugly enough to > cause confusion (sorry Chen Gang), but I don't see any immediate danger. > do not need 'sorry', learn with each other. (I am just learning through read kernel source code -- "code review") I am glad to know that my suggestion is useful (although it seems a minor suggestion). for me, it is enough. :-) thanks. -- Chen Gang Asianux Corporation