From: "Torsten Bögershausen" <tboegi@web.de>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/4] t4014: more tests about appending s-o-b lines
Date: Sun, 02 Dec 2012 08:06:44 +0100 [thread overview]
Message-ID: <50BAFE04.4080100@web.de> (raw)
In-Reply-To: <1353602289-9418-2-git-send-email-pclouds@gmail.com>
On 22.11.12 17:38, Nguyễn Thái Ngọc Duy wrote:
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> t/t4014-format-patch.sh | 145 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 145 insertions(+)
> + echo -n subject | append_signoff >actual &&
"echo -n" is not portable, and we use printf everywhere.
I found one "echo -n" in line 996.
Can we squeeze that in, before going to next?
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 6cfad13..f460930 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -993,7 +993,7 @@ EOF
'
test_expect_success 'signoff: commit with only subject that does not end with NL' '
- echo -n subject | append_signoff >actual &&
+ printf subject | append_signoff >actual &&
cat >expected <<\EOF &&
4:Subject: [PATCH] subject
8:
next prev parent reply other threads:[~2012-12-02 7:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 23:55 What's cooking in git.git (Nov 2012, #06; Mon, 19) Junio C Hamano
2012-11-20 1:41 ` Felipe Contreras
2012-11-20 11:59 ` Paul Fox
2012-11-20 23:50 ` Junio C Hamano
2012-11-21 0:05 ` Topics currently in the Stalled category Junio C Hamano
2012-11-21 3:31 ` Felipe Contreras
2012-11-28 2:59 ` Jeff King
2012-11-28 3:10 ` Felipe Contreras
2012-11-28 3:12 ` Jeff King
2012-11-28 3:11 ` Jeff King
2012-11-28 3:15 ` Felipe Contreras
2012-11-28 3:22 ` Jeff King
2012-11-28 3:33 ` Felipe Contreras
2012-11-21 14:55 ` Marc Branchaud
2012-11-22 11:24 ` Nguyen Thai Ngoc Duy
2012-11-22 16:38 ` [PATCH v2 0/4] nd/unify-appending-of-s-o-b Nguyễn Thái Ngọc Duy
2012-11-22 16:38 ` [PATCH v2 1/4] t4014: more tests about appending s-o-b lines Nguyễn Thái Ngọc Duy
2012-12-02 7:06 ` Torsten Bögershausen [this message]
2012-12-02 8:03 ` Brandon Casey
2012-11-22 16:38 ` [PATCH v2 2/4] format-patch: stricter S-o-b detection Nguyễn Thái Ngọc Duy
2012-11-22 16:38 ` [PATCH v2 3/4] format-patch: update append_signoff prototype Nguyễn Thái Ngọc Duy
2012-11-22 16:38 ` [PATCH v2 4/4] Unify appending signoff in format-patch, commit and sequencer Nguyễn Thái Ngọc Duy
2012-11-24 2:05 ` [PATCH v2 0/4] nd/unify-appending-of-s-o-b Junio C Hamano
2012-12-01 0:36 ` Topics currently in the Stalled category Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BAFE04.4080100@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.