[U-Boot] [PATCH] cm-t35: add USB host support

[Nikita Kiryanov <nikita@compulab.co.il>]

Hi Marek Vasut,

On 11/29/2012 12:36 AM, Marek Vasut wrote:
> Dear Nikita Kiryanov,
>
> [...]
>
>> +	twl4030_i2c_read_u8(TWL4030_CHIP_GPIO, &val,
>> +						TWL4030_BASEADD_GPIO + 0x03);
>> +	val |= 0xC0;
>
> What are these magic values here please?

val |= 0xC0 is simply setting bits 7 and 6 to 1.

As for TWL4030_BASEADD_GPIO + 0x03/0x0C, I'll address them in a V2.

>
>> +	/* Set GPIO6 and GPIO7 of TPS65930 as output */
>> +	twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, val,
>> +						TWL4030_BASEADD_GPIO + 0x03);
>> +	/* Take both PHYs out of reset */
>> +	twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0xC0,
>> +						TWL4030_BASEADD_GPIO + 0x0C);
>> +	udelay(1);
>> +
>> +	return omap_ehci_hcd_init(&usbhs_bdata);
> [...]
>
> Best regards,
> Marek Vasut
>


-- 
Regards,
Nikita.