From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] exofs: clean up the correct page collection on write
 error
Date: Sun, 2 Dec 2012 14:58:30 +0200
Message-ID: <50BB5076.3000703@panasas.com>
References: <1353941346-20598-1-git-send-email-idank@tonian.com> <50B8BE60.6090009@panasas.com> <CABpMAy+=3CP1nQ4m27xKjLnpn6dzvspW3WmfSjEJooLCqY8sdg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: <linux-fsdevel@vger.kernel.org>, <osd-dev@open-osd.org>,
	<solo@tonian.com>, <bhalevy@tonian.com>, <ilya@tonian.com>
To: Idan Kedar <idank@tonian.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from natasha.panasas.com ([67.152.220.90]:49182 "EHLO
	natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750838Ab2LBM6l (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 2 Dec 2012 07:58:41 -0500
In-Reply-To: <CABpMAy+=3CP1nQ4m27xKjLnpn6dzvspW3WmfSjEJooLCqY8sdg@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 12/02/2012 11:57 AM, Idan Kedar wrote:
> On Fri, Nov 30, 2012 at 4:10 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
<>
>>  err:
>> -       _unlock_pcol_pages(pcol, ret, WRITE);
>> -       pcol_free(pcol);
>> +       if (!pcol_copy) /* Failed before ownership transfer */
>> +               pcol_copy = pcol;
>> +       _unlock_pcol_pages(pcol_copy, ret, WRITE);
>> +       pcol_free(pcol_copy);
>>         kfree(pcol_copy);
>>
>>         return ret;
>> --
>> 1.7.10.2.677.gb6bc67f
>>
> 
> I started with that implementation, but it seemed less readable to me.
> 

I don't mind the readability, it is not that bad. But I do mind the extra
local variable I'd rather not have it. (I hate it when two places have the
same info, they get out of sync fast, I'd rather do with one)

> On Fri, Nov 30, 2012 at 4:15 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>> On 11/30/2012 04:10 PM, Boaz Harrosh wrote:
>>
>> I forgot to ask do you need this for stable?
>>
>> Boaz
> 
> nope.
> 

Thanks
Boaz