From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k_tasklet() can be interrupted by a hardware IRQ
Date: Mon, 03 Dec 2012 10:45:33 +0100 [thread overview]
Message-ID: <50BC74BD.8020807@openwrt.org> (raw)
In-Reply-To: <1AA9BD91549CF94C901B05C32D2B081101E002B9@ES02Ch.wgti.net>
On 2012-11-20 11:05 AM, Felix Liao wrote:
> Hi Felix F, I'm Felix Liao from WatchGuard, I think we should spin_lock_irqsave and spin_unlock_irqrestore on sc_pcu_lock
> in the ath9k_tasklet() instead of spin_lock/spin_unlock, just to avoid the tasklet being interrupted by the hardware IRQ,
> do you think so?
Using an IRQ spinlock in the tasklet is not the correct solution. If the
IRQ fires while the tasklet is running, it means that the driver does
not properly disable IRQs in the handler. They're supposed to get
disabled there and re-enabled only after the tasklet has completed.
- Felix
next prev parent reply other threads:[~2012-12-03 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 9:06 [ath9k-devel] ath9k_tasklet() can be interrupted by a hardware IRQ Felix Liao
2012-11-12 9:43 ` Adrian Chadd
2012-11-12 9:54 ` Felix Liao
2012-11-18 14:11 ` Adrian Chadd
2012-11-20 10:05 ` Felix Liao
2012-12-03 9:45 ` Felix Fietkau [this message]
2012-12-03 14:51 ` Chaoxing Lin
-- strict thread matches above, loose matches on Subject: below --
2012-11-12 2:09 Felix Liao
2012-11-09 1:33 Felix Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC74BD.8020807@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.