From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: [PATCH] dm: Update a source code comment Date: Mon, 03 Dec 2012 13:32:32 +0100 Message-ID: <50BC9BE0.30108@acm.org> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: dm-devel@redhat.com Cc: Jens Axboe , Jun'ichi Nomura , Tejun Heo , Alasdair G Kergon List-Id: dm-devel.ids Update a source code comment with the conclusions of the discussion of the patch that introduced this comment (commit a8c32a5). See also http://www.redhat.com/archives/dm-devel/2012-November/msg00003.html. Signed-off-by: Bart Van Assche Cc: Jens Axboe Cc: Alasdair G Kergon Cc: Jun'ichi Nomura Cc: Tejun Heo Cc: stable@vger.kernel.org --- drivers/md/dm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 77e6eff..0ec0673 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -740,12 +740,7 @@ static void rq_completed(struct mapped_device *md, int rw, int run_queue) if (!md_in_flight(md)) wake_up(&md->wait); - /* - * Run this off this callpath, as drivers could invoke end_io while - * inside their request_fn (and holding the queue lock). Calling - * back into ->request_fn() could deadlock attempting to grab the - * queue lock again. - */ + /* run queue asynchronously to minimize time spent in soft-IRQ ctxt */ if (run_queue) blk_run_queue_async(md->queue); -- 1.7.10.4