From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH 3/5] can: Kconfig: switch on CAN_RAW by default
Date: Mon, 03 Dec 2012 14:39:09 +0100 [thread overview]
Message-ID: <50BCAB7D.5070604@pengutronix.de> (raw)
In-Reply-To: <50B8E6AA.4090209@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]
On 11/30/2012 06:02 PM, Oliver Hartkopp wrote:
> On 30.11.2012 09:19, Marc Kleine-Budde wrote:
>
>> On 11/30/2012 07:47 AM, Oliver Hartkopp wrote:
>>> On 29.11.2012 14:58, Marc Kleine-Budde wrote:
>>>
>>>> As CAN_RAW is the basic CAN protocol, switch it on by default.
>>>>
>>>
>>>
>>> Hello Marc,
>>>
>>> you are probably right, that most users will at least need CAN_RAW sockets.
>>> But i asked myself, what the Linux distributions will do once we point out
>>> that a specific protocol is *preferred* to be enabled?
>>
>> I hope they enable it by default. However CAN_RAW will be only switched
>> on, if CAN support is enabled.
>>
>
> Yes, if CAN support is enabled.
>
> The problem is that when it's enabled - what to select then?
Sorry, I don't get what you're trying to tell me.
With my patch, if you switch on CAN support, CAN_RAW will be enabled by
default. My rationale behind is, that CAN support is pretty useless
without CAN_RAW support.
> IMO all entries (RAW/BCM/GW) should be enabled by default when CAN is
> selected. When people really know what they do, the might deselect entries at
> their own risc ...
YMMV, BCM and GW are for experienced can users. But I can change the
patch to enable RAW, BCM and GW on by default.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
next prev parent reply other threads:[~2012-12-03 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:58 [PATCH 0/5] clean up Kconfig + switch on CAN_RAW by default Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 1/5] can: Kconfig: convert 'depends on CAN' into 'if CAN...endif' block Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 2/5] can: Kconfig: convert 'depends on CAN_DEV' into 'if CAN_DEV...endif' block Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 3/5] can: Kconfig: switch on CAN_RAW by default Marc Kleine-Budde
2012-11-30 6:47 ` Oliver Hartkopp
2012-11-30 8:19 ` Marc Kleine-Budde
2012-11-30 17:02 ` Oliver Hartkopp
2012-12-03 13:39 ` Marc Kleine-Budde [this message]
2012-12-03 17:43 ` Oliver Hartkopp
2012-11-29 13:58 ` [PATCH 4/5] can: Kconfig: remove 'default n' from CAN_BCM and CAN_GW Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 5/5] can: sja1000: correct indention of Kconfig help text Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BCAB7D.5070604@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.