From: Michal Marek <mmarek@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scripts/tags.sh: Support compiled source
Date: Mon, 03 Dec 2012 17:39:39 +0100 [thread overview]
Message-ID: <50BCD5CB.2030506@suse.cz> (raw)
In-Reply-To: <1354551724-15089-2-git-send-email-js1304@gmail.com>
On 3.12.2012 17:22, Joonsoo Kim wrote:
> We usually have interst in compiled files only,
> because they are strongly related to individual's work.
> Current tags.sh can't select compiled files, so support it.
>
> We can use this functionality like below.
> "make cscope O=. SRCARCH=xxxx SUBARCH=compiled"
I like the idea, but please try to come up with a different syntax that
does not abuse SUBARCH.
> +all_compiled_sources()
> +{
> + for i in $(all_sources); do
> + if [[ $i =~ .*c$ || $i =~ .*S$ ]]; then
> + j=${i/\.[cS]/\.o}
Please use 'case "$i" in ...' instead of the bash-specific [[ ... ]]
construct.
Michal
next prev parent reply other threads:[~2012-12-03 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:22 [PATCH 1/2] scripts/tags.sh: Support subarch for ARM Joonsoo Kim
2012-12-03 16:22 ` [PATCH 2/2] scripts/tags.sh: Support compiled source Joonsoo Kim
2012-12-03 16:39 ` Michal Marek [this message]
2012-12-03 18:09 ` JoonSoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BCD5CB.2030506@suse.cz \
--to=mmarek@suse.cz \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.