From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory Date: Mon, 03 Dec 2012 10:26:24 -0700 Message-ID: <50BCE0C0.8000708@wwwdotorg.org> References: <1354058956-7199-1-git-send-email-swarren@wwwdotorg.org> <1354058956-7199-2-git-send-email-swarren@wwwdotorg.org> <50BCD030.7020908@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:36945 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214Ab2LCR0a (ORCPT ); Mon, 3 Dec 2012 12:26:30 -0500 In-Reply-To: <50BCD030.7020908@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: Michal Marek , Grant Likely , linux-arch@vger.kernel.org, Russell King , Arnd Bergmann , linux-kernel@vger.kernel.org, Olof Johansson , Stephen Warren , Sam Ravnborg , linux-arm-kernel@lists.infradead.org On 12/03/2012 09:15 AM, Rob Herring wrote: > On 11/27/2012 05:29 PM, Stephen Warren wrote: >> From: Grant Likely >> >> The current rules have the .dtb files build in a different directory >> from the .dts files. The only reason for this is that it was what >> PowerPC has done historically. This patch changes ARM to use the generic >> dtb rule which builds .dtb files in the same directory as the source .dts. > > [snip] > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index a17d5ab..cb217f8 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -136,4 +136,12 @@ dtb-$(CONFIG_ARCH_VT8500) += vt8500-bv07.dtb \ >> wm8650-mid.dtb >> dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb >> >> +targets += dtbs >> endif >> + >> +dtbs: $(addprefix $(obj)/, $(dtb-y)) >> + # *.dtb used to be generated in the directory above. Clean out the >> + # old build results so people don't accidentally use them. >> + rm -f $(obj)/../*.dtb > > Do you intend for this to print out? Seems a little noisy to me for a > one-time problem. Are you trying to tell users the dtb files moved or > just prevent them from using the old ones? Quietly removing them would > still accomplish the latter. Oh, I just wasn't thinking; I guess this should be @rm or similar. Will you fix this up locally since you've applied the patches? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 03 Dec 2012 10:26:24 -0700 Subject: [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory In-Reply-To: <50BCD030.7020908@gmail.com> References: <1354058956-7199-1-git-send-email-swarren@wwwdotorg.org> <1354058956-7199-2-git-send-email-swarren@wwwdotorg.org> <50BCD030.7020908@gmail.com> Message-ID: <50BCE0C0.8000708@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/03/2012 09:15 AM, Rob Herring wrote: > On 11/27/2012 05:29 PM, Stephen Warren wrote: >> From: Grant Likely >> >> The current rules have the .dtb files build in a different directory >> from the .dts files. The only reason for this is that it was what >> PowerPC has done historically. This patch changes ARM to use the generic >> dtb rule which builds .dtb files in the same directory as the source .dts. > > [snip] > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index a17d5ab..cb217f8 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -136,4 +136,12 @@ dtb-$(CONFIG_ARCH_VT8500) += vt8500-bv07.dtb \ >> wm8650-mid.dtb >> dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb >> >> +targets += dtbs >> endif >> + >> +dtbs: $(addprefix $(obj)/, $(dtb-y)) >> + # *.dtb used to be generated in the directory above. Clean out the >> + # old build results so people don't accidentally use them. >> + rm -f $(obj)/../*.dtb > > Do you intend for this to print out? Seems a little noisy to me for a > one-time problem. Are you trying to tell users the dtb files moved or > just prevent them from using the old ones? Quietly removing them would > still accomplish the latter. Oh, I just wasn't thinking; I guess this should be @rm or similar. Will you fix this up locally since you've applied the patches?