From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfjsA-00081q-Cp for qemu-devel@nongnu.org; Mon, 03 Dec 2012 23:12:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tfjs7-0002l1-RK for qemu-devel@nongnu.org; Mon, 03 Dec 2012 23:12:42 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:22735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfjs7-0002jq-Lh for qemu-devel@nongnu.org; Mon, 03 Dec 2012 23:12:39 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEH002WWNTCR300@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 04 Dec 2012 04:15:13 +0000 (GMT) Received: from [106.109.8.15] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MEH00MBYNOYYJ50@eusync3.samsung.com> for qemu-devel@nongnu.org; Tue, 04 Dec 2012 04:12:35 +0000 (GMT) Message-id: <50BD7830.9060501@samsung.com> Date: Tue, 04 Dec 2012 08:12:32 +0400 From: Evgeny Voevodin MIME-version: 1.0 References: <1354575357-24221-1-git-send-email-jcd@tribudubois.net> In-reply-to: <1354575357-24221-1-git-send-email-jcd@tribudubois.net> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] exynos4210/mct: Avoid infinite loop on non incremental timers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe DUBOIS Cc: Kyungmin Park , qemu-devel@nongnu.org On 12/04/2012 02:55 AM, Jean-Christophe DUBOIS wrote: > Check for a 0 "distance" value to avoid infinite loop when the > expired FCR timer was not programed with auto-increment. > > With this change the behavior is coherent with the same type > of code in the exynos4210_gfrc_restart() function in the same > file. > > Linux seems to mostly use this timer with auto-increment > which explain why it is not a problem most of the time. > > However other OS might have a problem with this if they > don't use the auto-increment feature. > > Signed-off-by: Jean-Christophe DUBOIS > --- > hw/exynos4210_mct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/exynos4210_mct.c b/hw/exynos4210_mct.c > index e79cd6a..37dbda9 100644 > --- a/hw/exynos4210_mct.c > +++ b/hw/exynos4210_mct.c > @@ -568,7 +568,7 @@ static void exynos4210_gfrc_event(void *opaque) > /* Reload FRC to reach nearest comparator */ > s->g_timer.curr_comp = exynos4210_gcomp_find(s); > distance = exynos4210_gcomp_get_distance(s, s->g_timer.curr_comp); > - if (distance > MCT_GT_COUNTER_STEP) { > + if (distance > MCT_GT_COUNTER_STEP || !distance) { > distance = MCT_GT_COUNTER_STEP; > } > exynos4210_gfrc_set_count(&s->g_timer, distance); > Reviewed-by: Evgeny Voevodin P.S.: Next time, please, don't forget to CC appropriate people to not let them miss your patch. -- Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, Samsung Moscow Research Center, e-mail: e.voevodin@samsung.com