From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tflk5-0001uj-Rd for qemu-devel@nongnu.org; Tue, 04 Dec 2012 01:12:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tfljy-0003kr-CU for qemu-devel@nongnu.org; Tue, 04 Dec 2012 01:12:29 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:23090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfkSM-00041A-IT for qemu-devel@nongnu.org; Mon, 03 Dec 2012 23:50:08 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEH00L8XPJMOV10@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 04 Dec 2012 04:52:40 +0000 (GMT) Received: from [106.109.8.15] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MEH005JHPFDFZ60@eusync2.samsung.com> for qemu-devel@nongnu.org; Tue, 04 Dec 2012 04:50:02 +0000 (GMT) Message-id: <50BD80F7.4050001@samsung.com> Date: Tue, 04 Dec 2012 08:49:59 +0400 From: Evgeny Voevodin MIME-version: 1.0 References: <1353483787-22308-1-git-send-email-e.voevodin@samsung.com> <50B2EDEE.3060102@samsung.com> In-reply-to: <50B2EDEE.3060102@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] TCG global gen_opc_ arrays clean-up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf , blauwirbel@gmail.com, kyungmin.park@samsung.com, av1474@comtv.ru, Paul Brook , edgar.iglesias@gmail.com, aurelien@aurel32.net, rth@twiddle.net On 11/26/2012 08:19 AM, Evgeny Voevodin wrote: > On 11/21/2012 11:43 AM, Evgeny Voevodin wrote: >> This set of patches moves global variables to tcg_ctx: >> gen_opc_instr >> gen_opparam_icount >> gen_opc_pc >> >> Build tested for all targets. >> Execution tested on Exynos4210 target. >> >> After this patchset was aplied, >> I noticed no speed-up or slow-down of code generation. >> >> Here is the test procedure: >> 1. Boot Linux Kernel 5 times. >> 2. For each iteration wait while "JIT cycles" is stable for ~10 seconds >> 3. Write down the "cycles/op" >> >> Here are the results (tested on gcc-4.6): >> >> Before clean-up: >> min: 655.5 >> max: 659.3 >> avg: 657.2 >> standard deviation: ~2 ~= 0.4% >> >> Average cycles/op = 657 +- 2 >> >> >> >> After clean-up: >> min: 654.6 >> max: 657.1 >> avg: 655.5 >> standard deviation: ~1 ~= 0.2% >> >> Average cycles/op = 656 +- 1 >> >> Evgeny Voevodin (5): >> tcg/tcg.h: Duplicate global TCG gen_opc_ arrays into TCGContext. >> TCG: Use gen_opc_pc from context instead of global variable. >> TCG: Use gen_opc_icount from context instead of global variable. >> TCG: Use gen_opc_instr_start from context instead of global variable. >> TCG: Remove unused global gen_opc_ arrays. >> >> exec-all.h | 4 ---- >> target-alpha/translate.c | 12 ++++++------ >> target-arm/translate.c | 12 ++++++------ >> target-cris/translate.c | 14 +++++++------- >> target-i386/translate.c | 19 ++++++++++--------- >> target-lm32/translate.c | 12 ++++++------ >> target-m68k/translate.c | 12 ++++++------ >> target-microblaze/translate.c | 12 ++++++------ >> target-mips/translate.c | 12 ++++++------ >> target-openrisc/translate.c | 12 ++++++------ >> target-ppc/translate.c | 12 ++++++------ >> target-s390x/translate.c | 12 ++++++------ >> target-sh4/translate.c | 12 ++++++------ >> target-sparc/translate.c | 12 ++++++------ >> target-unicore32/translate.c | 12 ++++++------ >> target-xtensa/translate.c | 10 +++++----- >> tcg/tcg.h | 3 +++ >> translate-all.c | 9 +++------ >> 18 files changed, 100 insertions(+), 103 deletions(-) >> > > Ping? > > +CC: Alexander Graf ; Paul Brook > Ping?? -- Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, Samsung Moscow Research Centre, e-mail: e.voevodin@samsung.com