From: Caspar Zhang <caspar@casparzhang.com>
To: Peng Haitao <penght@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 3/4] at_allow01: Use lib to restart atd service
Date: Tue, 04 Dec 2012 15:39:47 +0800 [thread overview]
Message-ID: <50BDA8C3.4070802@casparzhang.com> (raw)
In-Reply-To: <1354605716-4747-3-git-send-email-penght@cn.fujitsu.com>
On 12/04/2012 03:21 PM, Peng Haitao wrote:
> + 84» .·cmdlib.sh
Patch series looks good to me except this.
sourcing a lib inside a function seems not so good. Yet I don't see any
code style rules telling which is the correct place to put a shell lib
source (commonly I think it would be the top in the file)
Thanks,
Caspar
> + 85» restart_daemon·atd
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-12-04 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 7:21 [LTP] [PATCH 1/4] cmdlib.sh: Add four functions of controlling daemon Peng Haitao
2012-12-04 7:21 ` [LTP] [PATCH 2/4] runnetnstest.sh: fix a fail of vsftpd is disabled Peng Haitao
2012-12-07 7:50 ` Wanlong Gao
2012-12-04 7:21 ` [LTP] [PATCH 3/4] at_allow01: Use lib to restart atd service Peng Haitao
2012-12-04 7:39 ` Caspar Zhang [this message]
2012-12-04 9:17 ` Peng Haitao
2012-12-05 4:40 ` Caspar Zhang
2012-12-06 14:24 ` chrubis
2012-12-04 7:21 ` [LTP] [PATCH 4/4] at_deny01: " Peng Haitao
2012-12-07 7:50 ` [LTP] [PATCH 1/4] cmdlib.sh: Add four functions of controlling daemon Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BDA8C3.4070802@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=penght@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.