From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfxoS-0003dg-Nz
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:05:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfxoR-0007dJ-7g
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:05:48 -0500
Received: from cantor2.suse.de ([195.135.220.15]:38422 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfxoR-0007dE-0T
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 14:05:47 -0500
Message-ID: <50BE4987.4000500@suse.de>
Date: Tue, 04 Dec 2012 20:05:43 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1354627180-25704-1-git-send-email-ehabkost@redhat.com>
	<1354627180-25704-7-git-send-email-ehabkost@redhat.com>
	<CAAu8pHtVXCC6rHoL+S6xPW4vGpWAftOEwVsrwaneZNOOfsDFmA@mail.gmail.com>
	<20121204190129.GC4986@otherpad.lan.raisama.net>
In-Reply-To: <20121204190129.GC4986@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 6/8] qdev-properties.c: separate core from
 the code used only by qemu-system-*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

Am 04.12.2012 20:01, schrieb Eduardo Habkost:
> On Tue, Dec 04, 2012 at 06:55:17PM +0000, Blue Swirl wrote:
>> On Tue, Dec 4, 2012 at 1:19 PM, Eduardo Habkost <ehabkost@redhat.com> =
wrote:
>>> +static int parse_drive(DeviceState *dev, const char *str, void **ptr=
)
>>> +{
>>> +    BlockDriverState *bs;
>>> +
>>> +    bs =3D bdrv_find(str);
>>> +    if (bs =3D=3D NULL)
>>
>> Please add braces, use checkpatch.pl.
>>
>>> +        return -ENOENT;
>>> +    if (bdrv_attach_dev(bs, dev) < 0)
>>
>> Also here.
>=20
>=20
> This is pure code movement, and I won't introduce changes in the code
> while it is being moved to not make patch review harder.

> If you want to send coding style patches for that code after it is
> moved, be my guest.

No. Patches are required to pass checkpatch.pl (i.e., + lines in the
patch need braces). That means if not in the same patch for movement
reasons, Coding Style cleanups need to be done in advance, not as
followup. (same issue as in his AREG0 series)

Andreas

P.S. Dropping unrelated parts of the quotes makes requested changes
easier to spot. There was a ditto hidden somewhere down. ;)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg