From: George Dunlap <george.dunlap@eu.citrix.com>
To: Dario Faggioli <raistlin@linux.it>
Cc: xen-devel <xen-devel@lists.xensource.com>,
"Keir (Xen.org)" <keir@xen.org>
Subject: Re: [PATCH 3 of 3] xen: sched_credit: add some tracing
Date: Tue, 4 Dec 2012 19:10:58 +0000 [thread overview]
Message-ID: <50BE4AC2.9010507@eu.citrix.com> (raw)
In-Reply-To: <bf4b06eda19a03a6aa0b.1354552500@Solace>
On 03/12/12 16:35, Dario Faggioli wrote:
> + /* Avoid TRACE_* to avoid a lot of useless !tb_init_done checks */
> + for_each_cpu(cpu, &mask)
> + {
> + struct {
> + unsigned cpu:8;
> + } d;
> + d.cpu = cpu;
> + trace_var(TRC_CSCHED_TICKLE, 0,
> + sizeof(d),
> + (unsigned char*)&d);
Why not just TRC_1D()? The tracing infrastructure can only set the size
at a granularity of 32-bit words anyway, and at this point cpu is
"unsigned int", which will be a single word.
Other than that, everything looks good.
-George
next prev parent reply other threads:[~2012-12-04 19:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:34 [PATCH 0 of 3] xen: sched_credit: fix tickling and add some tracing Dario Faggioli
2012-12-03 16:34 ` [PATCH 1 of 3] xen: sched_credit, improve tickling of idle CPUs Dario Faggioli
2012-12-03 17:12 ` Ian Campbell
2012-12-03 18:26 ` Dario Faggioli
2012-12-05 12:16 ` George Dunlap
2012-12-03 16:34 ` [PATCH 2 of 3] xen: tracing: introduce per-scheduler trace event IDs Dario Faggioli
2012-12-04 18:53 ` George Dunlap
2012-12-04 18:55 ` George Dunlap
2012-12-05 11:57 ` Dario Faggioli
2012-12-03 16:35 ` [PATCH 3 of 3] xen: sched_credit: add some tracing Dario Faggioli
2012-12-04 19:10 ` George Dunlap [this message]
2012-12-05 11:54 ` Dario Faggioli
2012-12-05 11:51 ` George Dunlap
2012-12-05 12:01 ` Ian Campbell
2012-12-05 12:15 ` Dario Faggioli
2012-12-05 12:20 ` Ian Campbell
2012-12-05 12:25 ` George Dunlap
2012-12-05 12:38 ` Mats Petersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE4AC2.9010507@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=raistlin@linux.it \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.