From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: petarj@mips.com, Petar Jovanovic <petar.jovanovic@rt-rk.com>,
aurelien@aurel32.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV
Date: Tue, 04 Dec 2012 13:43:47 -0600 [thread overview]
Message-ID: <50BE5273.7090505@twiddle.net> (raw)
In-Reply-To: <CAAu8pHuJzKVVKWBX5JcanxESvzhKjywHTc4p+qLh2Gw7yW=1=A@mail.gmail.com>
On 2012-12-04 13:00, Blue Swirl wrote:
>> > + if (rs5_0 == 0)
>> > + return;
> The check should be moved to translation time so that the call to this
> helper is not generated at all.
No, we'd do that only if this value were an immediate.
Branch over helper is not an optimization for an edge case runtime value.
r~
next prev parent reply other threads:[~2012-12-05 0:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 14:49 [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV Petar Jovanovic
2012-12-04 19:00 ` Blue Swirl
2012-12-04 19:43 ` Richard Henderson [this message]
2012-12-04 19:52 ` Blue Swirl
2012-12-04 19:48 ` Jovanovic, Petar
2012-12-04 19:54 ` Blue Swirl
2012-12-04 21:13 ` Andreas Färber
2012-12-04 23:34 ` Jovanovic, Petar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE5273.7090505@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=petar.jovanovic@rt-rk.com \
--cc=petarj@mips.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.