From: Jan Kiszka <jan.kiszka@siemens.com>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Liu Ping Fan <qemulist@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs
Date: Wed, 05 Dec 2012 09:50:41 +0100 [thread overview]
Message-ID: <50BF0AE1.5010606@siemens.com> (raw)
In-Reply-To: <CAKjmthLpv42dAAbmtG4EbHu_QQ7=Qsf0qdiDCEsY4UC9SXrSpQ@mail.gmail.com>
On 2012-12-05 06:34, Cam Macdonell wrote:
>> static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address,
>> uint32_t val, int len)
>> {
>> + bool is_enabled, was_enabled = msi_enabled(pci_dev);
>> +
>> pci_default_write_config(pci_dev, address, val, len);
>> + is_enabled = msi_enabled(pci_dev);
>
> Problem 1) in my tests is_enabled is always 0, so I don't think the
> irqfds are getting setup
You likely want to call msix_enabled here.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-12-05 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 3:51 [Qemu-devel] [PATCH v2 1/2] ivshmem: remove msix_write_config Liu Ping Fan
2012-11-25 3:51 ` [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs Liu Ping Fan
2012-11-27 21:48 ` Cam Macdonell
2012-11-28 2:53 ` liu ping fan
2012-11-29 4:42 ` Cam Macdonell
2012-11-29 8:34 ` liu ping fan
2012-11-29 17:33 ` Cam Macdonell
2012-12-04 11:10 ` Andrew Jones
2012-12-05 3:17 ` Cam Macdonell
2012-12-05 9:25 ` Andrew Jones
2012-12-05 5:34 ` Cam Macdonell
2012-12-05 8:50 ` Jan Kiszka [this message]
2012-12-06 5:10 ` Cam Macdonell
2012-12-06 6:26 ` liu ping fan
2012-11-28 8:05 ` [Qemu-devel] [PATCH v2 1/2] ivshmem: remove msix_write_config liu ping fan
2012-12-05 5:38 ` Cam Macdonell
-- strict thread matches above, loose matches on Subject: below --
2012-12-06 6:37 Liu Ping Fan
2012-12-06 6:37 ` [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs Liu Ping Fan
2012-12-13 7:34 ` liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF0AE1.5010606@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=cam@cs.ualberta.ca \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.