From: Michal Marek <mmarek@suse.cz>
To: James Hogan <james.hogan@imgtec.com>
Cc: Takashi Iwai <tiwai@suse.de>, Rusty Russell <rusty@ozlabs.org>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source
Date: Wed, 05 Dec 2012 12:05:57 +0100 [thread overview]
Message-ID: <50BF2A95.9070704@suse.cz> (raw)
In-Reply-To: <50BF2262.7080603@imgtec.com>
Dne 5.12.2012 11:30, James Hogan napsal(a):
> However I think it's unfortunate having to stringify from C as it's
> pretty much always required to be in string form when used from a C
> file, usually in an asm block. Any objection to defining SYMBOL_PREFIX
> with the quotes around it for _c_flags only? E.g. see below
After Takashi's patch is applied, there will be no user of the
SYMBOL_PREFIX in C source. But it would probably be more convenient for
potential new users.
> +_c_sym_flags = -DSYMBOL_PREFIX=\"$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))\"
Maybe simply
-DDSYMBOL_PREFIX='$(or $(CONFIG_SYMBOL_PREFIX),"")'
? The single quotes are needed either way, to prevent the shell eating
the double quotes.
Michal
next prev parent reply other threads:[~2012-12-05 11:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 10:18 [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Michal Marek
2012-12-04 10:18 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source Michal Marek
2012-12-04 18:17 ` David Howells
2012-12-04 23:58 ` Rusty Russell
2012-12-05 7:39 ` Takashi Iwai
2012-12-05 9:50 ` Michal Marek
2012-12-05 10:06 ` Takashi Iwai
2012-12-05 10:30 ` James Hogan
2012-12-05 11:05 ` Michal Marek [this message]
2012-12-05 11:16 ` James Hogan
2012-12-07 4:40 ` Rusty Russell
2012-12-10 10:12 ` James Hogan
2012-12-05 10:30 ` David Howells
2012-12-05 10:54 ` Michal Marek
2012-12-05 12:35 ` David Howells
2012-12-05 7:46 ` Takashi Iwai
2012-12-04 10:18 ` [PATCH 3/3] MODSIGN: Drop ccache hack Michal Marek
2012-12-04 18:29 ` David Howells
2012-12-04 18:15 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file David Howells
2012-12-04 23:44 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF2A95.9070704@suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@ozlabs.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.