From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgXoG-0005dW-NT
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 04:32:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgXfl-0003Nj-Ht
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 04:23:21 -0500
Received: from greensocs.com ([87.106.252.221]:50780
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgXfl-0003Nc-8U
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 04:23:13 -0500
Message-ID: <50C063F5.1060801@greensocs.com>
Date: Thu, 06 Dec 2012 10:23:01 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1354631742-4693-1-git-send-email-fred.konrad@greensocs.com>
	<1354631742-4693-7-git-send-email-fred.konrad@greensocs.com>
	<CAFEAcA88zwZc8X0pmsa0DvC3=2o3ZpKUt=r3r8221SixX=pirg@mail.gmail.com>
	<50C06130.1090006@greensocs.com> <50C062E5.4070304@suse.de>
In-Reply-To: <50C062E5.4070304@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor
	virtio-blk.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com

On 06/12/2012 10:18, Andreas F=C3=A4rber wrote:
> Am 06.12.2012 10:11, schrieb KONRAD Fr=C3=A9d=C3=A9ric:
>> On 05/12/2012 17:25, Peter Maydell wrote:
>>> On 4 December 2012 14:35,  <fred.konrad@greensocs.com> wrote:
>>>> -static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
>>>> -{
>>>> -    return (VirtIOBlock *)vdev;
>>>> -}
>>>> +/*
>>>> + * Use the QOM cast, so we don't need that anymore.
>>>> + *
>>>> + * static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
>>>> + * {
>>>> + *     return (VirtIOBlock *)vdev;
>>>> + * }
>>>> + */
>>> If we don't need it, just delete it.
>>>
>>> -- PMM
>> Yes, sure, I put it in comment to explain, why I deleted it.
> Please don't comment out unneeded things. Instead, remove them
> completely and put the explanation into the commit message. That helps
> keep the patch small and avoids commented-out code bitrotting.
>
> Andreas
>
Ok, no problem.