From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: ehabkost@redhat.com, jan.kiszka@siemens.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, imammedo@redhat.com,
li guang <lig.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function
Date: Thu, 06 Dec 2012 10:57:05 +0100 [thread overview]
Message-ID: <50C06BF1.8000400@suse.de> (raw)
In-Reply-To: <CAFEAcA9jVT7hU4Y8pQ=XCkFdO5xV-Bp0fpfcZjBxowBRxGUR3g@mail.gmail.com>
Am 06.12.2012 10:48, schrieb Peter Maydell:
> On 6 December 2012 09:36, Andreas Färber <afaerber@suse.de> wrote:
>> The code comment specifically says "reset local breakpoints". IIUC you
>> are also resetting global breakpoints, which you shouldn't.
>>
>> Personally I'd be fine with a hw_local_breakpoint_enabled().
>
> The check you want is
> (hw_local_breakpoint_enabled() && !hw_global_breakpoint_enabled())
>
> if you're going to do it like that. [We don't want to take out the
> bp if it was enabled globally as well as locally.]
If it doesn't exist already (I'm assuming not, otherwise it could've
been used) we could simply define the "local" function to return false
if global is enabled. :) But maybe that's too clever.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-06 9:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 3:03 [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7 liguang
2012-12-06 3:03 ` [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type liguang
2012-12-06 3:03 ` [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function liguang
2012-12-06 8:54 ` Peter Maydell
2012-12-06 9:16 ` li guang
2012-12-06 9:23 ` Peter Maydell
2012-12-06 9:27 ` li guang
2012-12-06 9:35 ` 陳韋任 (Wei-Ren Chen)
2012-12-06 9:36 ` Andreas Färber
2012-12-06 9:48 ` Peter Maydell
2012-12-06 9:57 ` Andreas Färber [this message]
2012-12-07 0:53 ` li guang
2012-12-06 9:44 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 8:11 [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7 liguang
2012-12-04 8:11 ` [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function liguang
2012-12-04 18:51 ` Blue Swirl
2012-12-05 0:56 ` li guang
2012-12-05 8:55 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C06BF1.8000400@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.