All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <stefan.roese-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH] spi: spi-mpc52xx.c: Init bus_num to 0 as this driver only supports one bus
Date: Thu, 06 Dec 2012 15:50:09 +0100	[thread overview]
Message-ID: <50C0B0A1.4020908@gmail.com> (raw)
In-Reply-To: <20121206143720.3345F3E0948@localhost>

On 12/06/2012 03:37 PM, Grant Likely wrote:
> On Mon, 26 Nov 2012 11:09:47 +0100, Stefan Roese <sr-ynQEQJNshbs@public.gmane.org> wrote:
>> By setting bus_num to 0 the resulting device is named "spi0". Otherwise
>> the name was "spi32766" (dynamic numbering) which was a bit confusing.
>>
>> Using 0 is correct as this driver (and the MPC5200 SPI controller) only
>> supports one SPI bus.
> 
> But the chip has multiple SPI busses. If the psc spi bus gets probed
> first, then there will be a number conflict.

Yes, correct. Lets drop this patch for now then.

Thanks,
Stefan


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d

      reply	other threads:[~2012-12-06 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26 10:09 [PATCH] spi: spi-mpc52xx.c: Init bus_num to 0 as this driver only supports one bus Stefan Roese
     [not found] ` <1353924587-31339-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2012-12-06 14:37   ` Grant Likely
2012-12-06 14:50     ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C0B0A1.4020908@gmail.com \
    --to=stefan.roese-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=agust-ynQEQJNshbs@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.